Opened 11 years ago

Closed 9 years ago

#42149 closed defect (fixed)

mpeg4ip @1.5.0.1_3 does not compile on Mavericks or later

Reported by: Greisby (Greisberger Christophe) Owned by: reid@…
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: haspatch mavericks yosemite elcapitan Cc: ryandesign (Ryan Carsten Schmidt), fclaire@…, myk@…, kurthindenburg (Kurt Hindenburg)
Port: mpeg4ip

Description

The compilation fails with the following error: 

:info:build In file included from sys_block.cpp:52:
:info:build ./../include/bitstrm.hpp:48:10: fatal error: 'istream.h' file not found
:info:build #include <istream.h>
:info:build          ^
:info:build 1 error generated.
:info:build make[6]: *** [sys_block.lo] Error 1

The header is in /usr/include/c++/4.2.1/backward/

Here is a Portfile patch for Mavericks.

Attachments (4)

mpeg4ip_mavericks.patch​ (479 bytes) - added by Greisby (Greisberger Christophe) 11 years ago.
Portfile patch
Portfile.diff​ (527 bytes) - added by gthb (Gunnlaugur Thor Briem) 10 years ago.
Portfile patch to fix this issue with the patch that ryandesign linked to
patch-fix-ticket-42149.diff​ (7.9 KB) - added by gthb (Gunnlaugur Thor Briem) 10 years ago.
patch-fix-ticket-42149.diff
Portfile-mpeg4ip.diff​ (642 bytes) - added by fclaire@… 10 years ago.
Portfile patch including Yosemite support

Download all attachments as: .zip

Change History (14)

Changed 11 years ago by Greisby (Greisberger Christophe)

Attachment: mpeg4ip_mavericks.patch​ added

Portfile patch

comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added; reid@… removed
Owner: changed from macports-tickets@… to reid@…

It seems highly unlikely that that would be the correct solution. Instead, I'd look at a patch like this:

​https://github.com/salfter/portage/blob/master/media-video/mpeg4ip/files/mpeg4ip-1.5.0.1-gcc43.patch

comment:2 Changed 10 years ago by gthb (Gunnlaugur Thor Briem)

That patch linked in ticket:42149#1 works for me.

Changed 10 years ago by gthb (Gunnlaugur Thor Briem)

Attachment: Portfile.diff​ added

Portfile patch to fix this issue with the patch that ryandesign linked to

Changed 10 years ago by gthb (Gunnlaugur Thor Briem)

Attachment: patch-fix-ticket-42149.diff​ added

patch-fix-ticket-42149.diff

Changed 10 years ago by fclaire@…

Attachment: Portfile-mpeg4ip.diff​ added

Portfile patch including Yosemite support

comment:3 Changed 10 years ago by fclaire@…

I've just uploaded a Portfile patch to get this port compile under 10.10 Yosemite.

Could someone integrate all this into the macports repository ?

comment:4 Changed 10 years ago by fclaire@…

Cc: fclaire@… added

Cc Me!

comment:5 in reply to:  3 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to fclaire@…:

I've just uploaded a Portfile patch to get this port compile under 10.10 Yosemite.

As I said in comment:1, that's probably not the solution I would use. I would use the patch that fixes the source code, that comment:2 confirmed works.

comment:6 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: myk@… added
Keywords: yosemite elcapitan added
Summary: mpeg4ip @1.5.0.1_3 does not compile on Mavericks → mpeg4ip @1.5.0.1_3 does not compile on Mavericks or later

Has duplicate #47732.

comment:7 Changed 9 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:8 Changed 9 years ago by kurthindenburg (Kurt Hindenburg)

The sourceforge page no longer has the .tar.gz and all the macports mirrors only have the mpeg4ip-1.5.0.1.tar.gz.html

I can still commit the patch but can't really test it.

comment:9 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

I put a copy of the distfile on my server and updated the port to use it in r142166.

comment:10 Changed 9 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: → fixed
Status: new → closed

Thanks Ryan - patch committed r142169

Note: See TracTickets for help on using tickets.