Opened 11 years ago

Closed 11 years ago

#42159 closed defect (fixed)

libbiosig links with both MacPorts zlib and OS X zlib

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: neurodroid (Christoph Schmidt-Hieber)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: mojca (Mojca Miklavec)
Port: libbiosig

Description

Should link only with OS X zlib. 

$ port -v installed libbiosig
The following ports are currently installed:
  libbiosig @1.5.10_0-universal (active) platform='darwin 13' archs='x86_64'
$ otool -L /opt/local/lib/libbiosig.dylib
/opt/local/lib/libbiosig.dylib:
	/opt/local/lib/libbiosig.dylib (compatibility version 0.0.0, current version 0.0.0)
	/opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.8)
	/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.5)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 120.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1197.1.1)

Attachments (3)

Portfile-libbiosig.diff​ (1.1 KB) - added by neurodroid (Christoph Schmidt-Hieber) 11 years ago.
libbiosig Portfile diff to use only system zlib
patch-v3.diff​ (2.7 KB) - added by neurodroid (Christoph Schmidt-Hieber) 11 years ago.
More general patch that uses the private getline implementation only on SL and independently of MacPorts. See ticket #42152.
Portfile-libbiosig-libz-mp.diff​ (1.5 KB) - added by neurodroid (Christoph Schmidt-Hieber) 11 years ago.
libbiosig Portfile diff to use only MacPorts zlib

Download all attachments as: .zip

Change History (11)

comment:1 Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)

Just to be sure: /usr/lib/libz.1.dylib is preferred over /opt/local/lib/libz.1.dylib?

Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)

Attachment: Portfile-libbiosig.diff​ added

libbiosig Portfile diff to use only system zlib

Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)

Attachment: patch-v3.diff​ added

More general patch that uses the private getline implementation only on SL and independently of MacPorts. See ticket #42152.

comment:2 Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)

The attached Portfile patch (Portfile-libbiosig.diff​) links only with system zlib (/usr/lib/libz.1.dylib).

The attached source patch is from ticket #42152 - this would be a good opportunity to update the source patch as well.

comment:3 Changed 11 years ago by mojca (Mojca Miklavec)

Cc: mojca@… added

Cc Me!

comment:4 Changed 11 years ago by mojca (Mojca Miklavec)

A question for Ryan: does MacPorts really prefer linking with OS libraries like zlib? I knew that's the case in Homebrew, but I didn't know that MacPorts ports should also try to depend on /usr/lib in these cases. (I understand that the port shouldn't link against both though.)

comment:5 in reply to:  4 Changed 11 years ago by cooljeanius (Eric Gallager)

Replying to mojca@…:

A question for Ryan: does MacPorts really prefer linking with OS libraries like zlib?

wiki:FAQ#ownlibs suggests otherwise...

comment:6 in reply to:  description Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to ryandesign@…:

Should link only with OS X zlib.

Sorry, typo. Meant to say "should link only with MacPorts zlib".

Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)

Attachment: Portfile-libbiosig-libz-mp.diff​ added

libbiosig Portfile diff to use only MacPorts zlib

comment:7 Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)

The attached Portfile patch (Portfile-libbiosig-libz-mp.diff​) links only with MacPorts zlib (/opt/local/lib/libz.1.dylib).

comment:8 Changed 11 years ago by mojca (Mojca Miklavec)

Resolution: → fixed
Status: new → closed
Version: 2.2.1

Committed in r116171.

Note: See TracTickets for help on using tickets.