Opened 11 years ago
Closed 11 years ago
#42333 closed update (fixed)
OpenSSH: update to 6.5
| Reported by: | kentas@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | kenny@…, neverpanic (Clemens Lang), ci42, seanfarley (Sean Farley), nerdling (Jeremy Lavergne), raimue (Rainer Müller) | |
| Port: | openssh |
Description
OpenSSH 6.5 was released today with many new features. Can we get it in MacPorts?
Attachments (2)
Change History (15)
comment:1 follow-up: 2 Changed 11 years ago by neverpanic (Clemens Lang)
| Milestone: | MacPorts Future |
|---|---|
| Port: | openssh added; net/openssh removed |
| Summary: | OpenSSH 6.5 → OpenSSH: update to 6.5 |
| Type: | request → update |
comment:2 Changed 11 years ago by kentas@…
Replying to cal@…:
A common oversight when updating OpenSSH are the variants and different patches we provide for OpenSSH, such as the HPN patch. I assume that one probably has not been updated to 6.5 yet?
https://github.com/bdrewery/openssh/commit/7d7e36ee7496a5afbf209d787ae3207b5af55903
comment:3 Changed 11 years ago by neverpanic (Clemens Lang)
That just bumps the patch URL to what it should be, but the patch isn't there on the sourceforge servers in the hpnssh project.
comment:5 Changed 11 years ago by mlindgren@…
The FreeBSD guys use this patch, hopefully it proves useful: http://mirror.shatow.net/freebsd/openssh/openssh-6.5p1-hpnssh14v2.diff.gz
comment:6 Changed 11 years ago by mlindgren@…
Hello again. I have created a port for 6.5 and tested with +HPN. I also enabled PIE functionality (--with-pie). Hopefully this looks ok: https://www.dropbox.com/s/y0ydouu5qtsqery/openssh.tar.gz
comment:7 Changed 11 years ago by nerdling (Jeremy Lavergne)
| Cc: | cal@… ciserlohn@… sean@… dluke@… snc@… added |
|---|
comment:9 Changed 11 years ago by danielluke (Daniel J. Luke)
| Cc: | dluke@… removed |
|---|
comment:10 follow-ups: 11 12 Changed 11 years ago by raimue (Rainer Müller)
Just for the next time, spaces are usually preferred instead of tabs in Portfiles. Mixing them both is bad practice, but that can be corrected easily.
The referenced file openssh-6.5p1-hpnssh14v2.diff.gz is missing from the tarball.
Also, you are changing UsePrivilegeSeparation sandbox to UsePrivilegeSeparation yes. I guess that would be because of #36291. In such a case I would always appreciate a link to the ticket in the Portfile as otherwise nobody knows why it was done. Finding the cause of the problem would be preferred, but that should be discussed in the other ticket.
comment:11 Changed 11 years ago by raimue (Rainer Müller)
Replying to raimue@…:
The referenced file
openssh-6.5p1-hpnssh14v2.diff.gzis missing from the tarball.
My bad, sorry. The file is meant to be downloaded, so that is not an issue.
Changed 11 years ago by raimue (Rainer Müller)
| Attachment: | openssh-6.5p1.diff added |
|---|
Portfile as extracted from tarball, no other files were changed. Fixed whitespace.
comment:12 Changed 11 years ago by mlindgren@…
Replying to raimue@…:
Just for the next time, spaces are usually preferred instead of tabs in Portfiles. Mixing them both is bad practice, but that can be corrected easily.
The referenced file
openssh-6.5p1-hpnssh14v2.diff.gzis missing from the tarball.Also, you are changing
UsePrivilegeSeparation sandboxtoUsePrivilegeSeparation yes. I guess that would be because of #36291. In such a case I would always appreciate a link to the ticket in the Portfile as otherwise nobody knows why it was done. Finding the cause of the problem would be preferred, but that should be discussed in the other ticket.
Sorry about the whitespace issue. Yes, I could not get sandboxing to work properly, so I went with PrivilegeSeparation yes as is the default in OpenSSH 6.4. Let me know if I need to make a change before you commit.
comment:13 Changed 11 years ago by neverpanic (Clemens Lang)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
A common oversight when updating OpenSSH are the variants and different patches we provide for OpenSSH, such as the HPN patch. I assume that one probably has not been updated to 6.5 yet?