avrdude: Opportunistic use of libelf headers

[raimue (Rainer Müller)]

avrdude uses libelf headers if the port is installed prior to compilation, but does not declare the appropriate dependency.

With libelf:

$ port -q installed \( libelf avrdude \) and active
  avrdude @6.0.1_0 (active)
  libelf @0.8.13_2 (active)
$ sudo port -v configure avrdude
[...]
Configuration summary:
----------------------
DO HAVE    libelf
[...]

Without libelf:

$ port -q installed \( libelf avrdude \) and active
  avrdude @6.0.1_0 (active)
$ sudo port -v configure avrdude
[...]
Configuration summary:
----------------------
DON'T HAVE libelf
[...]

This means the resulting binary changes whether libelf was active at the time of compilation or not. Builds are meant to be reproducible, they should not change due to factors not declared in the Portfile.

[cooljeanius (Eric Gallager)]

Cc Me!

[macports@…]

Patch to enforce the libelf dependency

[macports@…]

The easiest solution would be to enforce a dependency on libelf (see attached patch). Chances are probably pretty low that someone wants to use avrdude without ELF support, so we don't need an extra variant.

[macports@…]

Cc Me!

[g5pw (Aljaž Srebrnič)]

Fixed by explicitly depending on libelf in r120473.