Opened 11 years ago

Closed 11 years ago

#42510 closed submission (fixed)

p5-math-mpfi 0.04 submission

Reported by: someuser12 Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: p5-math-mpfi

Description

Perl interface to the MPFI (interval arithmetic) library.

Attachments (2)

Portfile (502 bytes) - added by someuser12 11 years ago.
Portfile.2 (820 bytes) - added by someuser12 11 years ago.

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by someuser12

Attachment: Portfile added

comment:1 Changed 11 years ago by mf2k (Frank Schima)

This port depends on #42509 for mpfi to be added.

Here's a quick review:

  • The license field needs to be added.
  • A sha256 checksum should be added. The sha1 checksum can be removed unless upstream provides it.
  • Add perl 5.18 unless it does not work with it.
  • Since it uses a portgroup, use depends_lib-append instead of depends_lib
  • Does this port really compile a library? If not, then the line supported_archs noarch should be added

comment:2 in reply to:  1 Changed 11 years ago by someuser12

Replying to macsforever2000@…:

This port depends on #42509 for mpfi to be added.

Here's a quick review:

Thanks a lot for your review. I tried to address all issues in Portfile.2 (by the way, I had forgotten one dependency). It seems the module cannot be tested with perl5.18 yet since p5-math-mpfr is not yet available for perl5.18.

Changed 11 years ago by someuser12

Attachment: Portfile.2 added

comment:3 Changed 11 years ago by mf2k (Frank Schima)

Port: p5-math-mpfi added
Version: 2.2.1

comment:4 Changed 11 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed

Added in r119954 with the following changes:

  • Moved the mpfi dependency into the if {${perl5.major} != ""} { block so the stub port does not have any dependencies.
  • Moved lines around to be consistent with other perl ports.
  • Removed the p5.18 sub-port.
Note: See TracTickets for help on using tickets.