libquvi-scripts: libquvi-scripts/0.9/common/quvi/youtube.lua requires 'socket.url', missing lua dependencies.

[dbevans (David B. Evans)]

When I run totem I get the following critical warning:

** (totem-pl-parser-videosite:39219): CRITICAL **: [_chk_script_ident] .../local/share/libquvi-scripts/0.9/common/quvi/youtube.lua:109: module 'socket.url' not found:
	no field package.preload['socket.url']
	no file '/opt/local/share/lua/5.2/socket/url.lua'
	no file '/opt/local/share/lua/5.2/socket/url/init.lua'
	no file '/opt/local/lib/lua/5.2/socket/url.lua'
	no file '/opt/local/lib/lua/5.2/socket/url/init.lua'
	no file './socket/url.lua'
	no file '/opt/local/share/libquvi-scripts/0.9/common/socket/url.lua'
	no file '/opt/local/lib/lua/5.2/socket/url.so'
	no file '/opt/local/lib/lua/5.2/loadall.so'
	no file './socket/url.so'
	no file '/opt/local/lib/lua/5.2/socket.so'
	no file '/opt/local/lib/lua/5.2/loadall.so'
	no file './socket.so'

Looking at /opt/local/share/libquvi-scripts/0.9/common/quvi/youtube.lua:109

function M.normalize(url)
  if not url then
    return url
  end

  local U = require 'socket.url'

[dbevans (David B. Evans)]

After looking into this further, this appears to be due to missing dependencies.

socket.url is provided by 3rd party lua package luasocket (MacPorts lua-luasocket). The libquvi-scripts README file confirms this dependency as well as several others.

Requirements
------------

* Lua BitOp 1.0.1
  http://bitop.luajit.org/
    $ sudo aptitude install lua-bitop

* LuaExpat 1.2.0
  http://matthewwild.co.uk/projects/luaexpat/
    $ sudo aptitude install lua-expat

* LuaJSON 1.1.1
  http://www.eharning.us/wiki/luajson/
    $ sudo aptitude install lua-json

* LuaSocket 2.0.2
  http://w3.impa.br/~diego/software/luasocket/
    $ sudo aptitude install lua-socket

Unfortunately, the lua-luasocket port is broken as the current version only supports lua 5.1 and we're at lua 5.2.2 now (#35858).

Attached for review is an admittedly hackish work-around that fixes the problem reported here by taking the url.lua script from lua-luasocket and manually installing it into the libquvi-scripts common script directory. Grepping of the code shows that this is the only script required from lua-luasocket and the patch fixes totem's immediate problem, but there are undoubtedly other similar problems related to the other 3rd party packages -- I just haven't run in to them yet.

[dbevans (David B. Evans)]

Proposed patch for review

[dbevans (David B. Evans)]

Status of missing dependencies:

• lua-luasocket needs to be updated for lua 5.2 compatibility (#35858)
• lua-luaexpat also needs to be updated for lua 5.2 compatibility (#41846).
• luajson is not ported yet, available from ​https://github.com/harningt/luajson.
• luabitop is not ported yet, available from ​https://github.com/LuaDist/luabitop.

[nerdling (Jeremy Lavergne)]

lua-luasocket updated in r119354.

lua-luajson added in r119358.

[cooljeanius (Eric Gallager)]

Cc Me!

[nerdling (Jeremy Lavergne)]

Now that all the packages are available, added dependencies and revbumped in r119363.