Opened 11 years ago

Closed 9 years ago

Last modified 9 years ago

#42552 closed submission (fixed)

New port: mp3cat

Reported by: xythobuz@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: kurthindenburg (Kurt Hindenburg), ryandesign (Ryan Carsten Schmidt)
Port: mp3cat

Description

mp3cat - reads and writes MP3 files

Attachments (2)

patch-Makefile.diff​ (353 bytes) - added by xythobuz@… 11 years ago.
Portfile​ (902 bytes) - added by xythobuz@… 11 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Thanks. Some observations:

  • Because you're using use_configure no, you need to add code to ensure you're UsingTheRightCompiler and -arch flags and add a universal variant if possible.
  • The destroot phase can be simplified (reduced to a single line) by using xinstall's -W flag.
  • The homepage variable is missing.
  • The modeline is missing.

Changed 11 years ago by xythobuz@…

Attachment: patch-Makefile.diff​ added

Changed 11 years ago by xythobuz@…

Attachment: Portfile​ added

comment:2 Changed 11 years ago by xythobuz@…

Thank you for your suggestions.

I added the homepage and modeline and reduced the destroot phase to a single line. I also patched the Makefile, so it is now using the specified Compiler. However, I'm not sure how to go about adding a universal variant without using a configure script...?

comment:3 Changed 9 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:4 Changed 9 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: → fixed
Status: new → closed

done r139509

comment:5 in reply to:  2 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added

Replying to xythobuz@…:

However, I'm not sure how to go about adding a universal variant without using a configure script...?

Added universal variant in r140054.

Note: See TracTickets for help on using tickets.