py*-keyring @0.6.2_0: update to 3.5

[mail@…]

The package py-keyring is outdated, the latest version is 3.5

I modified the Portfile, and it seems to work on my machine with python2.7. See the attached diff.

Additional testing required, especially newer python version (3.x).

[mail@…]

Unified diff of Portfile

[ryandesign (Ryan Carsten Schmidt)]

Thanks. Some observations:

• Your patch removes the $Id$ line. Please leave it in place.
• You set the maintainers line to "ojkastl". We would be glad to have you take over maintenance of this unmaintained port, however the maintainers line must be your valid email address, and should be in our obfuscated host:user format. Omitting the host part means the host part is "macports.org", and since you are not a committer, you do not have a macports.org email address, so you need to list the host part.
• You removed the post-destroot installation of documentation and demos. Is this because those files no longer exist in the distribution? Or because the software now automatically installs those files?

[mail@…]

Ryan, thanks for the feedback.

ad 1) I just deleted every line I was not sure of, so the $ld$ line was deleted too (Is there any documentation about what this line does? I found none in the guide, but maybe I overlooked it...). I changed that in my second patch.

ad 2) I just forgot to delete the maintainer before patching, this was just for me to know that I made the changes. Also changed.

ad 3) I just deleted the lines, cos I could not get it to build with it. I did not have time to dig into that, I was hoping someone with more knowledge might come along and help... ;-)

[mail@…]

I got the livecheck to work. Patch #3

[petrrr]

I at a quick look at your patch, here some considerations:

• Looking quick at PyPI, I would assume there no support for Python 2.4 and 2.5 anymore, so you might want to check this;
• Consider also if you really want to support Python 3.1 and maybe even 3.2 could be already left out;
• I learned it is better, to have the livecheck active only for the main port and deactivate it for the subports;

[mail@…]

ad 1) I just tested py27 and py34, I was hoping someone else could test the others...

ad 2) See 1). I was hoping someone would test these.

ad 3) How would I deactive the livecheck for the subports? A block similar to what I deleted for the post-destroot?

if {${name} ne ${subport}} {

[mail@…]

Version5 of the patch has a working post-destroot. The names of some files had changed, that was what has broken my first tries.

[petrrr]

Cc Me!

[mf2k (Frank Schima)]

Please add a sha256 checksum and remove the sha1 and md5 checksums unless upstream publishes those.

[petrrr]

PyPI usually provides md5 checksum, so I usually put them in my Portfiles as well, sha1 should probably be replaced.

BTW: checking for the md5 checksum I realised, the package was updated recently to 3.6, you may want to consider this update.

The homepage is redirected to https protocol as well, I personally would change this as well. But I am not sure if this is required by some guideline.

[petrrr]

Note that the update to 3.6 was implemented in r117631. So this ticket might be closed.

However, the changeset r117631, differs in the following details discussed above:

• livecheck is not disabled for subports;
• homepage is redirected;
• python.default_version 27 should now not be required;

[g5pw (Aljaž Srebrnič)]

Hello! I was the one updating the port and didn't notice there already was an open ticket for its update. The changes above are implemented in r117770. I took the liberty of setting the homepage to the one indicated in setup.py. ojkastl, would you like to take maintainership of this port?

[mail@…]

Replying to g5pw@…:

ojkastl, would you like to take maintainership of this port?

I'm glad, someone with more knowledge has taken over, so, no, thanks! ;-)

[petrrr]

Replying to mail@…:

Replying to g5pw@…:

ojkastl, would you like to take maintainership of this port?

I'm glad, someone with more knowledge has taken over, so, no, thanks! ;-)

Just go ahead and give it a try! As maintainer you look after updates or fixes occasionally. That's how it starts all ;-). You will not have commit rights immediately, this way your patches are are review and if you have some doubts just ask the developer list.