New port for fxload

[DanielO (Daniel O'Connor)]

I ported fxload (used to upload firmware to Cypress EZ-USB devices) from FreeBSD.

[ryandesign (Ryan Carsten Schmidt)]

Thanks. Some observations:

• Since this project is hosted at bitbucket, consider using the bitbucket portgroup.
• Since you're using "use_configure no", you need to add code to ensure you're UsingTheRightCompiler and -arch flags and add a universal variant.
• ${prefix} already begins with a slash; you shouldn't add another one before it.
• Manpages go in ${prefix}/share/man, not ${prefix}/man.
• You don't need to create standard directories in destroot; MacPorts creates them for you.

[DanielO (Daniel O'Connor)]

Thanks for the feedback.

I am not sure about the portgroup thing, I couldn't find any examples when I googled, can you show me one?

I think I've fixed the other issues, see the tar ball I uploaded.

Note that while I added a universal variant I didn't test it because I don't have the tool chain installed (I tried but MP wanted to install many things I didn't have time for), I believe the code will work correctly as both though.

[ryandesign (Ryan Carsten Schmidt)]

• The universal variant won't work as written because you haven't included -arch flags anywhere. Add "[get_canonical_archflags cc]" to MP_CFLAGS and "[get_canonical_archflags ld]" to MP_LDFLAGS. Alternately, instead of patching the Makefile and introducing new variables, sometimes I just use CC="${configure.cc} [get_canonical_archflags cc]" and be done with it.
• You can grep the existing portfiles to find ports using the bitbucket portgroup. Or just read the bitbucket portgroup file itself​ for basic usage information.

[ryandesign (Ryan Carsten Schmidt)]

• There is no need to enclose the setting of the build.args in a pre-build block, since the values you're using are not being influenced by any variants.
• Please convert all tabs to spaces.
• Please obfuscate your email address in the maintainers line using our host:user format.

[DanielO (Daniel O'Connor)]

Won't it be problematic if I don't add arch flags to the linker? (i.e. why does [get_canonical_archflags ld] exist?)

[DanielO (Daniel O'Connor)]

I've updated the Portfile to remove the patch and make the other changes you suggested.

[larryv (Lawrence Velázquez)]

Replying to darius@…:

Won't it be problematic if I don't add arch flags to the linker?

That depends on how the build system links its object files. Sometimes it’s necessary, sometimes it isn’t.

[DanielO (Daniel O'Connor)]

Replying to larryv@…:

Replying to darius@…:

Won't it be problematic if I don't add arch flags to the linker?

That depends on how the build system links its object files. Sometimes it’s necessary, sometimes it isn’t.

So for maximum robustness the patch is probably a good idea?

I don't care either way, but I'd like to not have to handle bug reports about it later ;)

[DanielO (Daniel O'Connor)]

Any progress on this? I just tested it on Yosemite and it seems to work fine.