[update] py-construct to 2.5.1

[jul_bsd@…]

• update to 2.5.1
• remove restriction to python 2.4, 2.5
• dependency of Plaso (Ticket #42394)

[mf2k (Frank Schima)]

Trac requires complete and non-obfuscated email addresses.

Please do not mix spacing adjustments and functional changes in the same patch.

[macfreek (Freek Dijkstra)]

@jul_bsd: Thanks for the patch!

I've slightly modified the patch to:

• add Python versions 3.1, 3.2, and 3.3 (​http://construct.readthedocs.org/en/latest/ says it supports 2.5-3.3). I suspect 3.4 will work too.
• Added py-six as dependency, since that is now required (I tested this with Python 2.7 and 3.3).
• Ignore whitespace changes (I think they're fine, but apparently this is what macsforever2000 requested)
• Removed my email from the maintainers list, as I'm no longer using py-construct at the moment.

@macsforever2000: What do you mean with "Trac requires complete and non-obfuscated email addresses."?

[macfreek (Freek Dijkstra)]

Patchfile for rsync.macports.org/release/tarballs/ports/python/py-construct/Portfile to update py-construct to 2.51

[macfreek (Freek Dijkstra)]

(on second thought, I added Python 3.4 as well, since it seems to work fine)

[larryv (Lawrence Velázquez)]

Replying to software@…:

@macsforever2000: What do you mean with "Trac requires complete and non-obfuscated email addresses."?

He means that Trac requires normal “name@domain” email addresses, or else notification emails will not be delivered to the intended recipients. The obfuscated “domain:name” addresses used in Portfiles don’t work.

[jul_bsd@…]

@macreek cool! Thanks for the update. miss a few things it seems.

[macfreek (Freek Dijkstra)]

jul_bsd: could you test and report? If so, you or me can ask if this patch can be applied. (I don't have write access myself).

• mkdir py-construct-test; cd py-construct-test
• cp /opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/python/py-construct/Portfile ./
• wget ​http://trac.macports.org/raw-attachment/ticket/42653/patch-py_construct-2.51-Portfile.diff
• patch Portfile < patch-py_construct-2.51-Portfile.diff
• port install subport=py27-construct
• python2.7 -c "import construct"

[jul_bsd@…]

• build/install ok
• /opt/local/bin/python2.7 -c "import construct" is good (without path, it goes to Apple one)
• 2.4 is Nok

$ port build subport=py24-construct
Warning: MacPorts running without privileges. You may be unable to complete certain actions (e.g. install).
--->  Computing dependencies for py24-construct
Error: Dependency 'py24-six' not found.
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets
Error: Processing of port py-construct failed

and yes py-six Portfile is from 25 to 34.

[jul_bsd@…]

any other questions pending?

for py-six, as official website says python 2.5+, I think we can probably remove 2.4 from py-construct too.

[macfreek (Freek Dijkstra)]

Agreed. ​http://construct.readthedocs.org/en/latest/ indeed mentions "Python 2.5-3.3".

A small correction: if we're dropping Py24 support, we can leave out the "subport py24-construct" bit.

See attachment.

[macfreek (Freek Dijkstra)]

Patchfile for rsync.macports.org/release/tarballs/ports/python/py-construct/Portfile

[mf2k (Frank Schima)]

Your patch does not actually apply for me:

$ patch Portfile patch-py_construct-2.51-Portfile.3.diff 
patching file Portfile
patch: **** malformed patch at line 34: -    # Python 2.4 (and it works fine with Python 2.5 too)

Also per lint, please determine and add the correct license:

$ port lint --nitpick py27-construct 
--->  Verifying Portfile for py27-construct
Warning: no license set
--->  0 errors and 1 warnings found.

[jul_bsd@…]

• port lint --nitpick
• livecheck
• /tab/spacex4/

[jul_bsd@…]

seems t has been fixed to 2.52 by stromnov@

​http://trac.macports.org/log/trunk/dports/python/py-construct/Portfile?rev=119557

from what was said on this thread, still not fixed

• remove support for 24
• add support for 31 32
• remove a maintainer software@…

[mf2k (Frank Schima)]

Done in r120516. I also added py26.

[jul_bsd@…]

Thanks mf2k@