Opened 11 years ago
Closed 11 years ago
#42669 closed enhancement (fixed)
ola @0.9.0 new upstream release
Reported by: | nomis52@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.2.1 |
Keywords: | haspatch maintainer | Cc: | p3k (Tobi Schäfer) |
Port: | ola |
Description
Update to reflect the new upstream release. The releases are now hosted on github and the website has moved.
Attachments (1)
Change History (10)
comment:1 Changed 11 years ago by nomis52@…
comment:3 Changed 11 years ago by mojca (Mojca Miklavec)
First of all, an accidental checksum ended up in the first line of your patch. Please remove that. Other than that ...
I find it a bit weird to use
master_sites ${github.homepage}/releases/download/${github.version}
together with the GitHub PortGroup. But I see that one would actually need different checksums, running autoreconf
before being able to configure the port etc. (The download is slightly different from the tagged version.)
Changed 11 years ago by nomis52@…
Attachment: | Portfile.diff added |
---|
comment:4 Changed 11 years ago by nomis52@…
Sorry about that, I've fixed the patch.
If there is a better way to do the download let me know. I think I ended up copying that from another port because it was the only way I could get it working.
Simon
comment:5 Changed 11 years ago by g5pw (Aljaž Srebrnič)
Well, master_sites
should be set up automatically by the github
PortGroup. Do you download from a tag?
comment:6 Changed 11 years ago by nomis52@…
Not tags but releases: https://github.com/OpenLightingProject/ola/releases
comment:7 Changed 11 years ago by g5pw (Aljaž Srebrnič)
But releases are tied to tags (you can see the tag name just below the "Latest release"). So we can use that to keep the portfile as simple as possible.
comment:8 Changed 11 years ago by nomis52@…
There are two different archives though, the official ola-0.X.Y.tar.gz and the auto-generated snapshot at the 0.X.Y tag. We want people to use the former.
comment:9 Changed 11 years ago by g5pw (Aljaž Srebrnič)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Ah, I see. Fine by me then! Commited in r118219.
Can someone take a look at this please? It's been 3 weeks.