ROOT : Update to 5.34.17 + Remove X11 dependencies when using Cocoa

[cjones051073 (Chris Jones)]

Hi,

Update to latest 5.34.17 upstream version (yes, upstream skipped 5.34.16 for some reason...).

Also adds a new x11 variant that contains all explicit dependencies on 'X11' ports. Conflicts with cocoa variant, only one can be active at once. Defaults are the same, cocoa on OSX 10.8 onwards, X11 on older systems. However, upstream have confirmed this is the default in ROOT mainly because they only test on 10.8 onwards these days. I would be happy to switch to using cocoa by default on 10.7 or perhaps even older, if anyone can confirm this works fine on these systems (including from PyRoot, which was previously an issue).

Chris

[mojca (Mojca Miklavec)]

Cc Me!

[mojca (Mojca Miklavec)]

Next time please try to use something like

--- Portfile.orig
+++ Portfile

instead of the long paths (no need to upload again now).

I usually do a svn checkout and just run svn diff.

[cjones051073 (Chris Jones)]

OK, I'll try and remember but no guarantees ;)

I normally just run a diff of my local version against the last released Portfile, from the /<prefix>/etc... area. The long path is not my fault, but MacPorts decision on where it stores the Portfiles... ;)

Chris

[mojca (Mojca Miklavec)]

(If you use a svn checkout instead of unversioned files, you get a lot of nice functionality "for free".)

I'm trying to compile root on my machine now and I'm waiting for it to finish. Once it does, I'll commit the change. Do you give me the permission to make +cocoa default on 10.7?

[cjones051073 (Chris Jones)]

If it works on OS X 10.7 then yes, please make it the default.

*However*, please make sure you test python support. So install with one of the python variants, +python27 say, then from the python prompt verify you can import ROOT and create a TCanvas() properly. i.e. at the prompt

> import ROOT
> ROOT.TCanvas()

If you see a window, it works...

This used to be an issue with older ROOT releases when the cocoa variant was enabled, which was primarily why I never made it the default. It works fine on OSX10.9 now (I haven't tested 10.8, I only personally have 10.9, but upstream confirm it works OK as well).

This needs to work before I am happy to make it the default on anything older.

cheers Chris

[mojca (Mojca Miklavec)]

I committed r117542. I need to take another hour for a new compilation to be able to test the python support ;)

[cjones051073 (Chris Jones)]

Thanks, but wouldn't it have been better to test OSX 10.7 with +cocoa+python *before* committing, then if it is OK updating it to use cocoa by default at the same time ? By committing now, you have triggered a buildbot build of the binaries. If you update svn again to change the OSX10.7 default, that will trigger yet another build (and you will have to update the revision), which seems a little unnecessary to me.

Anyway, no major deal, thanks for committing and testing it ;)

cheers Chris

[cjones051073 (Chris Jones)]

I just noticed a small typo in the Portfile... When/if you do update OSX10.7 default, could you also correct

variant x11 conflicts cocoa {Enables X11 graphical backend} {

to

variant x11 conflicts cocoa description {Enables X11 graphical backend} {

... Doh...

Chris

[mojca (Mojca Miklavec)]

It would probably be better to wait, but I wasn't sure when I would be back online.

Just to comfort you: there is no need to increase the revision and if there is no increase in revision the binaries won't be rebuilt on the buildbot (except for Lion).

[mojca (Mojca Miklavec)]

Also, in order to steal some of your attention ... I would be grateful if you could take a look at CMake whenever you find a tiny bit of free time. I can offer you assistance with it. The sooner we can polish the configuration-related problems, the better.

(I think I have a solution for parallel installation of ROOT 5 and 6 and I think that ROOT 6 is ready enough to start providing a package in MacPorts. I gladly volunteer as a (co)maintainer of ROOT 6, but I wouldn't want to end up with two diverging installations of ROOT 5 and 6 with different maintainers etc.)

[mojca (Mojca Miklavec)]

I tested Python now. I do get the window and no errors or warnings. I have no clue how to use it though ;)

So based on your instructions I'm going to lower the number. And if I have time, I might even test in on a virtual machine running 10.6. I suggest to ask the upstream to lower that number as well.

[mojca (Mojca Miklavec)]

Make +cocoa default on 10.7 and add the missing keyword in r117545.

[cjones051073 (Chris Jones)]

Replying to mojca@…:

Also, in order to steal some of your attention ... I would be grateful if you could take a look at CMake whenever you find a tiny bit of free time. I can offer you assistance with it. The sooner we can polish the configuration-related problems, the better.

(I think I have a solution for parallel installation of ROOT 5 and 6 and I think that ROOT 6 is ready enough to start providing a package in MacPorts. I gladly volunteer as a (co)maintainer of ROOT 6, but I wouldn't want to end up with two diverging installations of ROOT 5 and 6 with different maintainers etc.)

Its really just a matter of my finding time... Updating the normal portfle for new releases takes me next to no time, but learning cmake is going to take longer.... Can you remind me though where you host your root5/root6 portfiles for testing ?

Are the cmake issues fully resolved though ? I don't want to switch root5 to it unless it has no regressions compared to the 'normal' build ?

Could we perhaps consider switching to cmake only for root6, but keep root5 on as it is ? Or do you have an interest in moving root5 to cmake as well ?

Chris