Opened 11 years ago
Closed 11 years ago
#42730 closed submission (fixed)
pngquant @2.1.0 Portfile
Reported by: | lpancescu (Laurențiu Păncescu) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.2.1 |
Keywords: | haspatch | Cc: | |
Port: | pngquant |
Description
Could you add an official port for pngquant, please? It uses advanced algorithms to create lossy, indexed PNG files, almost identical to the original, but typically 50-70% smaller (see http://pngquant.org).
I managed to create a Portfile after skimming through the MacPorts documentation. I doubt it's up to the MacPorts standards, but it works for me on OS X 10.9.2, so maybe it's okay as a starting point.
Attachments (1)
Change History (3)
Changed 11 years ago by lpancescu (Laurențiu Păncescu)
comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Owner: | changed from macports-tickets@… to ryandesign@… |
---|---|
Status: | new → assigned |
comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Committed in r117656 with these changes:
- adjust whitespace to conform to modeline (indents at multiples of 4 spaces)
- use github portgroup
- download distfile from homepage, since that's where the download link takes you, and because those are bz2 files, which are smaller than the gz files github offers
- patch Makefile to remove incorrect assumptions about where it should look for dependencies
- ensure we're UsingTheRightCompiler and
-arch
flags - add universal variant and set
ARFLAGS
in order to add thes
flag which makes the universal build succeed; equivalently, we could have patched lib/Makefile to runranlib
after runningar
- use destroot.env instead of destroot.post_args, thereby eliminating the need to specify destroot.destdir again
- all build environment variables needed to be copied to the destroot, so I used
eval
to accomplish that - add dependency on zlib, since the Makefile does use the flag
-lz
- install documentation files
Note: See
TracTickets for help on using
tickets.
Thanks, this is a good start.