BUG: mysql56 fails to build universal on Mavericks

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

r114637 fixed #40865, but I think it may have fixed it twice.
I believe this code is unnecessary

    if {[string match *clang* ${configure.cxx}] &&
              ${os.major} >= 13} {

        configure.args-append \
                        -DCMAKE_CXX_FLAGS:STRING="-stdlib=libstdc++"
    }

since upgrading to 5.6.15 (​https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-15.html) was sufficient.

I do not know if there is any other reason to use libstdc++, but setting CMAKE_CXX_FLAGS breaks the universal build because cmake then ignores CXXFLAGS, which is is where -arch is set.

If libstdc++ is still needed, may I suggest that the following would allow the universal build to continue to work.

    if {[string match *clang* ${configure.cxx}] &&
              ${os.major} >= 13} {

        configure.cxxflags-append \
                        -stdlib=libstdc++
    }

I have attached both possible fixes.

[pixilla (Bradley Giesbrecht)]

See r118041

Thanks mcalhoun.