Opened 11 years ago

Closed 6 years ago

#42955 closed defect (fixed)

x264 @20140124_1 Build failure vs Xcode v5.1 (5B130a)

Reported by: scdeimos+macports.org@… Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: xcode51 Cc: llamafilm, mason@…
Port: x264

Description (last modified by dbevans (David B. Evans))

x264 @20140124_1 OS X v10.9.2 Xcode v5.1 (5B130a) Apple LLVM version 5.1 (clang-503.0.38)

Install x264 fails with the following error in config.log:

clang: error: unknown argument: '-falign-loops=16' [-Wunused-command-line-argument-hard-error-in-future]
clang: note: this will be a hard error (cannot be downgraded to a warning) in the future

It appears that the x264/Portfile:post-path method is not correctly detecting clang, so it is failing to remove the "-falgin-loops=16" configure option.

The following workaround is not currently usable (downloading llvm-3.3-3.3_1.darwin_13.x86_64.tbz2 times out):

sudo port clean x264
sudo port install apple-gcc42
sudo port install x264 configure.compiler=apple-gcc-4.2

The following hack allows install to complete:

mkdir ~/ports/multimedia/x264
cd ~/ports/multimedia/x264
cp /opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/multimedia/x264/Portfile .
echo "#Fix error:" >> Portfile
echo "#clang: error: unknown argument: '-falign-loops=16' [-Wunused-command-line-argument-hard-error-in-future]" >> Portfile
echo "#clang: note: this will be a hard error (cannot be downgraded to a warning) in the future" >> Portfile
echo "configure.cflags-append -Qunused-arguments" >> Portfile
echo "configure.cppflags-append -Qunused-arguments" >> Portfile
cd ~/ports
portindex
sudo port install x264

HTH, Anthony.

Change History (7)

comment:1 Changed 11 years ago by dbevans (David B. Evans)

Description: modified (diff)
Keywords: xcode51 added; mavericks removed
Owner: changed from macports-tickets@… to devans@…
Status: newassigned

Will take a look.

In the future, please make sure to Cc: the maintainer of the port and to use WikiFormatting to improve the readability of plain text such as terminal output and quotations from logs.

comment:2 in reply to:  1 Changed 11 years ago by scdeimos+macports.org@…

Replying to devans@…:

Will take a look.

In the future, please make sure to Cc: the maintainer of the port and to use WikiFormatting to improve the readability of plain text such as terminal output and quotations from logs.

Thank you. Please forgive the missing Cc, this was my first submission. Note also that the formatting controls (and the direction to "use WikiFormatting") do not appear unless JavaScript is enabled in the browser.

comment:3 Changed 11 years ago by llamafilm

Cc: elliottbalsley@… added

Cc Me!

comment:4 Changed 10 years ago by os@…

on yosemite, the hack by the original poster doesn't work any more, presumably because the unused argument is now an error as opposed to a warning. i'm not familiar enough with macports to fix this, but making the "reinplace" command in the post-patch section unconditional (i.e., commenting out the enclosing if clause) makes the install succeed.

Last edited 10 years ago by os@… (previous) (diff)

comment:5 Changed 10 years ago by mason@…

Cc: mason@… added
Last edited 10 years ago by mason@… (previous) (diff)

comment:6 Changed 10 years ago by mason@…

This issue can be resolved by simply removing the following line from the configure file:

CFLAGS="$CFLAGS -falign-loops=16"

comment:7 Changed 6 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: assignedclosed

Fixed for some time now. Current versions of x264 (at least version 1.7.0+) no longer use -falign-loops=16 in CFLAGS.

Note: See TracTickets for help on using tickets.