patch.args do not support being overwritten inside variants

[yeled@…]

The original issue is thus:

I have many patches to a Portfile. Some of these need patch.args -p1, some need -p0.

If we add a patch.args to a variant {} it uses a patch.args-append logic. This doesn't work because patch(1) will use the first instance of the -p switch.

To fix this I would ask for patch.args to support a replacement of the overall Portfile patch.args switch. But this could be extended to be more sane.

What I am asking for is a -replace logic to arguments passed on. For all arguments. configure.args- replace for instance.

This would allow us to have a sane way of having more complexe Portfiles that could incase +stable and +devel variants within one "dport".

What do you think?

C.

[yeled@…]

* Bug 4314 has been marked as a duplicate of this bug. *

[yeled@…]

this is a sample Portfile for how I imagine it working.

PortSystem 1.0 name foo <etc>.. use_bzip2 yes patch.args -p1

variant another_patch { patch_sites-append ​http://foo.bar/ patchfiles-append patch.1 patch.args -p0 checksums-append patch.1 md5 a37a990057444edaef0bba57d8b7c0f1 }

currently simply adding another patch.args will append the args to the command - ending up with this:

"patch -p1 -p0 < patch.1"

Talking to Paul Guyot and he agrees that the latter is a bug..

the rest is more likely a feature request..

[yeled@…]

the Portfile that I'm having issues with.

[pguyot (Paul Guyot)]

I figured it out. The -p argument is a pre_arg, not an arg. You need to do: patch.pre_args -p1

Does the documentation mention otherwise?