#43155 closed defect (fixed)
qalculate-gtk fails build on Mavericks
Reported by: | jjstickel (Jonathan Stickel) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.2.1 |
Keywords: | haspatch | Cc: | mojca (Mojca Miklavec), macportbugs@…, Ionic (Mihai Moldovan), mkae (Marko Käning) |
Port: | qalculate-gtk |
Description
qalculate-gtk fails to build on Mavericks. As per macsforever2000 (ticket #42889):
:info:build ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ :info:build ./support.h:25:21: note: expanded from macro '_' :info:build # define _(String) dgettext (PACKAGE, String) :info:build ^~~~~~~~~~~~~~~~~~~~~~~~~~ :info:build callbacks.cc:12498:38: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat] :info:build pos_str = g_strdup_printf("%i", i_column + 1 + matrix_edit_columns.size() * gtk_tree_path_get_indices(path)[0]); :info:build ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ :info:build %lu :info:build callbacks.cc:12662:38: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat] :info:build pos_str = g_strdup_printf("%i", i_column + 1 + matrix_columns.size() * gtk_tree_path_get_indices(path)[0]); :info:build ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ :info:build %lu :info:build In file included from callbacks.cc:30: :info:build In file included from ./callbacks.h:24: :info:build In file included from ./main.h:33: :info:build In file included from /opt/local/include/libqalculate/qalculate.h:15: :info:build In file included from /opt/local/include/libqalculate/includes.h:21: :info:build In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/vector:265: :info:build In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/__bit_reference:15: :info:build /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/algorithm:685:97: error: invalid operands to binary expression ('const tree_struct' and 'const tree_struct') :info:build _LIBCPP_INLINE_VISIBILITY bool operator()(const _T1& __x, const _T1& __y) const {return __x < __y;} :info:build ~~~ ^ ~~~
Attachments (3)
Change History (13)
comment:1 Changed 11 years ago by mf2k (Frank Schima)
Cc: | mojca@… added |
---|
Changed 11 years ago by mf2k (Frank Schima)
comment:2 Changed 11 years ago by macportbugs@…
Cc: | macportbugs@… added |
---|
comment:3 Changed 11 years ago by Ionic (Mihai Moldovan)
Right... doing what clang suggests makes qalculate-gtk compile.
I fixed the issue locally on my system whilst building, but was obviously too lazy to make a real patch. I'll get that, as dirty as it may be.
Really wish qalculate would have been updated within the last 4 years. :(
Changed 11 years ago by Ionic (Mihai Moldovan)
Attachment: | qalculate-gtk-const.diff added |
---|
Fix build failure due to missing const in tree_struct sorting operator.
comment:5 Changed 11 years ago by Ionic (Mihai Moldovan)
The other compile warnings are just that, warnings. We can ignore them (although they hint at bad code quality, but that's an upstream problem...)
comment:6 Changed 11 years ago by mkae (Marko Käning)
Keywords: | haspatch added |
---|
Changed 10 years ago by Ionic (Mihai Moldovan)
Attachment: | qalculate-gtk.portfile.patch added |
---|
Add previously provided patch to Portfile.
comment:8 Changed 10 years ago by jjstickel (Jonathan Stickel)
Yep, feel free to commit this without my input. I am still on Mountain Lion anyway. I'll try to take a look at this in the next couple weeks to make sure it didn't break anything, though.
comment:9 Changed 10 years ago by mkae (Marko Käning)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Fixed in r121596
Cc Me!