#43309 closed update (fixed)
tmux @1.8 patch attached to update tmux to 1.9a
Reported by: | tessus (Helmut K. C. Tessarek) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.2.1 |
Keywords: | haspatch | Cc: | rafi (Rafael Bodill), jones@…, larryv (Lawrence Velázquez), jrobertray@…, cooljeanius (Eric Gallager) |
Port: | tmux |
Description
I've updated the tmux Portfile:
- updated version to 1.9a
- removed unnecessary patchfiles, configure.env, livecheck
Attachments (1)
Change History (6)
Changed 11 years ago by tessus (Helmut K. C. Tessarek)
Attachment: | Portfile-tmux.diff added |
---|
comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | justrafi@… jones@… larryv@… jrobertray@… egall@… added |
---|---|
Keywords: | haspatch added |
Owner: | changed from macports-tickets@… to ryandesign@… |
Status: | new → assigned |
comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Thanks for the update. I committed it in r118741 with these changes:
- I did not commit your removal of some whitespace because I prefer some whitespace between parts of the portfile
- I removed the "revision 1" line because the first revision of any version of a port should be 0.
- I did not remove the livecheck lines because although the livecheck wasn't working, removing the lines didn't fix it; instead I fixed the livecheck.regex.
- I rewrote the master_sites to avoid redirects.
comment:3 Changed 11 years ago by tessus (Helmut K. C. Tessarek)
Thanks for comitting the changes. Removing the empty lines was a mistake on my side. my bad.
btw, just as an info: I tested my Portfile locally and it worked perfectly (w/o your changes) - wrt livecheck and master_sites
comment:4 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
The old value of master_sites would have worked, but would have incurred HTTP redirects and some other side effects described at wiki:howto/AvoidRedirects which we want to avoid.
Regarding the livecheck, I've just checked again, and removing the livecheck lines results in the following behavior:
$ port livecheck tmux Error: cannot check if tmux was updated (regex didn't match) $
Whereas the livecheck lines as I committed them result in the following behavior:
$ port livecheck tmux $
(correctly indicating that no newer version of the software exists).
comment:5 Changed 11 years ago by tessus (Helmut K. C. Tessarek)
Thanks for the info. I'm new to writing portfiles and I haven't run the command $ port livecheck tmux
, I just did a $ port upgrade tmux
and it downloaded the file and everything seemed ok.
Now I know for the next time. :-) Cheers.
Supersedes #42661 and #43219 which had requested this update.