Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#43367 closed defect (fixed)

codeblocks @13.12: fix the patch for addition of -lfontconfig flag

Reported by: iain.a.brown@… Owned by: mojca (Mojca Miklavec)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: codeblocks

Description (last modified by mf2k (Frank Schima))

Executing port install codeblocks or port install codeblocks +x11 both fail with

:info:patch patching file src/plugins/contrib/source_exporter/Makefile.in
:info:patch Hunk #1 FAILED at 392.
:info:patch 1 out of 1 hunk FAILED -- saving rejects to file src/plugins/contrib/source_exporter/Makefile.in.rej
:info:patch Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_codeblocks/codeblocks/work/codeblocks-13.12" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/devel/codeblocks/files/patch-src-plugins-contrib-source_exporter-Makefile.diff'
:info:patch Exit code: 1
:error:patch org.macports.patch for port codeblocks returned: command execution failed
:debug:patch Error code: CHILDSTATUS 21382 1
:debug:patch Backtrace: command execution failed
    while executing
"system $fullcmdstring"
    ("eval" body line 1)
    invoked from within
"eval system $notty $nice \$fullcmdstring"
    invoked from within
"command_exec patch "" "< '$patch'""
    (procedure "portpatch::patch_main" line 35)
    invoked from within
"$procedure $targetname"
:info:patch Warning: targets not executed for codeblocks: org.macports.activate org.macports.patch org.macports.configure org.macports.build org.macports.destroot org.macports.install

Using OSX 10.9.2 on a late 2008 Core 2 Duo and XCode 5.1.1

Change History (6)

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Description: modified (diff)
Owner: changed from macports-tickets@… to mojca@…
Port: codeblocks added

In the future, please use WikiFormatting, fill in the Port field and Cc the port maintainers (port info --maintainers codeblocks).

comment:2 Changed 11 years ago by mojca (Mojca Miklavec)

A pure speculation and an ugly workaround would be the following replacement for patch-src-plugins-contrib-source_exporter-Makefile.diff:

--- src/plugins/contrib/source_exporter/Makefile.in.orig
+++ src/plugins/contrib/source_exporter/Makefile.in
@@ -398,7 +398,7 @@ AM_CPPFLAGS = $(WX_CXXFLAGS) \
 
 pluginlibdir = $(pkglibdir)/plugins
 pluginlib_LTLIBRARIES = libexporter.la
-libexporter_la_LDFLAGS = -module -version-info 0:1:0 -shared -no-undefined -avoid-version
+libexporter_la_LDFLAGS = -module -version-info 0:1:0 -shared -no-undefined -avoid-version -lfontconfig
 libexporter_la_LIBADD = ../../../sdk/libcodeblocks.la \
                                wxPdfDocument/libwxPdfDocument.la \
                                $(WX_LIBS) $(CB_FONTCONFIG_LIBS)

But I see that there's a new flag CB_FONTCONFIG_LIBS. I need a bit more testing.

comment:3 Changed 11 years ago by mojca (Mojca Miklavec)

Summary: codeblocks-13.12 failscodeblocks @13.12: fix the patch for addition of -lfontconfig flag
Version: 2.2.1

comment:4 Changed 11 years ago by mojca (Mojca Miklavec)

Resolution: fixed
Status: newclosed

It turns out that the latest release was already working properly, so I simply removed the patch and added some more in r119054.

Please let me know if there are still problems (including new ones introduced by the changes).

comment:5 Changed 11 years ago by mojca (Mojca Miklavec)

The latest commit is related to the following upstream tickets:

comment:6 Changed 11 years ago by iain.a.brown@…

That's building perfectly now, thank you very much.

Note: See TracTickets for help on using tickets.