Opened 19 years ago

Closed 19 years ago

Last modified 19 years ago

#4354 closed defect (fixed)

port -t finds excess undeclared dependencies

Reported by: ben@… Owned by: pguyot (Paul Guyot)
Priority: Normal Milestone:
Component: base Version: 1.0
Keywords: Cc:
Port:

Description

Paul,

port -t is really cool -- it certainly helps a lot with my KDE deps problems. But I noticed a couple of wrinkles. First, it seems to think some declared dependencies haven't been declared:

$ sudo port -vdt install qt3 ... Warning: trace revealed an undeclared dependency on ccache Warning: trace revealed an undeclared dependency on ccache Warning: trace revealed an undeclared dependency on cups-headers Warning: trace revealed an undeclared dependency on jpeg Warning: trace revealed an undeclared dependency on libpng Warning: trace revealed an undeclared dependency on zlib Warning: trace revealed an undeclared dependency on perl5.8

But some of these _are_ declared in the Portfile: depends_lib lib:libGL.1:XFree86 lib:libX11.6:XFree86 \

lib:libfreetype.6:XFree86 lib:libpng.3:libpng \ lib:libjpeg.62:jpeg

[Obviously ccache should just be ignored].

I'll file another bug for the other problem.

Change History (8)

comment:1 Changed 19 years ago by pguyot (Paul Guyot)

Status: newassigned

Did you start from a fully clean qt3?

The thing is that qt3 is awfully long to configure & compile, and I would be happier if I knew which phase produced incorrect dependency warnings.

I'll try a full build anyway, but not immediatly, I need some CPU cycles.

comment:2 Changed 19 years ago by ben@…

The thing is that qt3 is awfully long to configure & compile, and I would be happier if I knew which phase produced incorrect dependency warnings.

I'll keep an eye out for a better test case.

comment:3 Changed 19 years ago by pguyot (Paul Guyot)

Reminder: One problem is that port -t doesn't honor variants (including default variants).

comment:4 Changed 19 years ago by pguyot (Paul Guyot)

Ahah. Ben, did you check this against the portfile before portindex was run?

I cannot reproduce the problem here, but PortIndex was updated since you reported the bug.

I think the actual bug is that -t checks dependencies against the index instead of checking against what actually are the dependencies (including those from the variants).

comment:5 Changed 19 years ago by ben@…

Nope, that's not it (though I think -t _should_ use the deps list in the Portfile, because tracing is most useful when debugging, when the Portfile is very likely to be out of sync with the portindex.

Here's another example, less huge than qt3:

[ben@assam dports] $ portindex ... Total number of ports parsed: 2717 Ports successfully parsed: 2717 Ports failed: 0

[ben@assam dports] $ sudo port -vdt configure libsdl_image Password: DEBUG: Found port in file:///Users/ben/projects/darwinports/dports/devel/libsdl_image DEBUG: Changing to port directory: /Users/ben/projects/darwinports/dports/devel/libsdl_image DEBUG: Requested variant powerpc is not provided by port libsdl_image. DEBUG: Requested variant darwin is not provided by port libsdl_image. DEBUG: Requested variant macosx is not provided by port libsdl_image. Portfile changed since last build; discarding previous state. DEBUG: Found port in file:///Users/ben/projects/darwinports/dports/devel/libsdl DEBUG: Changing to port directory: /Users/ben/projects/darwinports/dports/devel/libsdl DEBUG: Searching for dependency: libsdl DEBUG: Found Dependency: receipt exists for libsdl DEBUG: Found port in file:///Users/ben/projects/darwinports/dports/graphics/libpng DEBUG: Changing to port directory: /Users/ben/projects/darwinports/dports/graphics/libpng DEBUG: Searching for dependency: libpng DEBUG: Found Dependency: receipt exists for libpng DEBUG: Found port in file:///Users/ben/projects/darwinports/dports/graphics/jpeg DEBUG: Changing to port directory: /Users/ben/projects/darwinports/dports/graphics/jpeg DEBUG: Searching for dependency: jpeg DEBUG: Found Dependency: receipt exists for jpeg DEBUG: Portfile changed since installation DEBUG: Executing com.apple.main (libsdl_image) DEBUG: Portfile changed since installation ---> Fetching libsdl_image DEBUG: Executing com.apple.fetch (libsdl_image) DEBUG: Portfile changed since installation ---> Verifying checksum(s) for libsdl_image DEBUG: Executing com.apple.checksum (libsdl_image) ---> Checksumming SDL_image-1.2.4.tar.gz DEBUG: Correct (md5) checksum for SDL_image-1.2.4.tar.gz DEBUG: Portfile changed since installation ---> Extracting libsdl_image DEBUG: Executing com.apple.extract (libsdl_image) ---> Extracting SDL_image-1.2.4.tar.gz DEBUG: setting option extract.args to /opt/local/var/db/dports/distfiles/libsdl_image/SDL_image-1.2.4.tar.gz DEBUG: Assembled command: 'cd "/opt/local/var/db/dports/build/file._Users_ben_projects_darwinports_dports_devel_libsdl_image/work" && gzip -dc /opt/local/var/db/dports/distfiles/libsdl_image/SDL_image-1.2.4.tar.gz | /usr/bin/gnutar --no-same-owner -xf -' DEBUG: Portfile changed since installation DEBUG: Executing com.apple.patch (libsdl_image) DEBUG: Portfile changed since installation ---> Configuring libsdl_image DEBUG: Executing com.apple.configure (libsdl_image) DEBUG: Assembled command: 'cd "/opt/local/var/db/dports/build/file._Users_ben_projects_darwinports_dports_devel_libsdl_image/work/SDL_image-1.2.4" && CFLAGS="-I/opt/local/include" LDFLAGS="-L/opt/local/lib" ./configure --prefix=/opt/local --disable-sdltest' checking build system type... powerpc-apple-darwin8.2.0 checking host system type... powerpc-apple-darwin8.2.0 checking target system type... powerpc-apple-darwin8.2.0 checking for a BSD-compatible install... /opt/local/bin/ginstall -c checking whether build environment is sane... yes checking for gawk... no checking for mawk... no checking for nawk... no checking for awk... awk checking whether make sets $(MAKE)... yes checking whether to enable maintainer-specific portions of Makefiles... no checking for style of include used by make... GNU checking for gcc... gcc checking for C compiler default output file name... a.out checking whether the C compiler works... yes checking whether we are cross compiling... no checking for suffix of executables... checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ANSI C... none needed checking dependency style of gcc... gcc3 checking for a sed that does not truncate output... /usr/bin/sed checking for egrep... grep -E checking for ld used by gcc... /usr/bin/ld checking if the linker (/usr/bin/ld) is GNU ld... no checking for /usr/bin/ld option to reload object files... -r checking for BSD-compatible nm... /usr/bin/nm -p checking whether ln -s works... yes checking how to recognise dependent libraries... pass_all checking how to run the C preprocessor... gcc -E checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unistd.h... yes checking dlfcn.h usability... yes checking dlfcn.h presence... yes checking for dlfcn.h... yes checking for g++... g++ checking whether we are using the GNU C++ compiler... yes checking whether g++ accepts -g... yes checking dependency style of g++... gcc3 checking how to run the C++ preprocessor... g++ -E checking for g77... no checking for f77... no checking for xlf... no checking for frt... no checking for pgf77... no checking for fort77... no checking for fl32... no checking for af77... no checking for f90... no checking for xlf90... no checking for pgf90... no checking for epcf90... no checking for f95... no checking for fort... no checking for xlf95... no checking for ifc... no checking for efc... no checking for pgf95... no checking for lf95... no checking for gfortran... no checking whether we are using the GNU Fortran 77 compiler... no checking whether accepts -g... no checking the maximum length of command line arguments... 65536 checking command to parse /usr/bin/nm -p output from gcc object... ok checking for objdir... .libs checking for ar... ar checking for ranlib... ranlib checking for strip... strip checking if gcc static flag works... yes checking if gcc supports -fno-rtti -fno-exceptions... no checking for gcc option to produce PIC... -fno-common checking if gcc PIC flag -fno-common works... yes checking if gcc supports -c -o file.o... yes checking whether the gcc linker (/usr/bin/ld) supports shared libraries... yes checking dynamic linker characteristics... darwin8.2.0 dyld checking how to hardcode library paths into programs... immediate checking whether stripping libraries is possible... yes checking if libtool supports shared libraries... yes checking whether to build shared libraries... yes checking whether to build static libraries... yes configure: creating libtool appending configuration tag "CXX" to libtool checking for ld used by g++... /usr/bin/ld checking if the linker (/usr/bin/ld) is GNU ld... no checking whether the g++ linker (/usr/bin/ld) supports shared libraries... yes checking for g++ option to produce PIC... -fno-common checking if g++ PIC flag -fno-common works... yes checking if g++ supports -c -o file.o... yes checking whether the g++ linker (/usr/bin/ld) supports shared libraries... yes checking dynamic linker characteristics... darwin8.2.0 dyld checking how to hardcode library paths into programs... immediate checking whether stripping libraries is possible... yes appending configuration tag "F77" to libtool checking whether make sets $(MAKE)... (cached) yes checking for gcc... (cached) gcc checking whether we are using the GNU C compiler... (cached) yes checking whether gcc accepts -g... (cached) yes checking for gcc option to accept ANSI C... (cached) none needed checking dependency style of gcc... (cached) gcc3 checking for inline... inline checking for a BSD-compatible install... /opt/local/bin/ginstall -c checking for sdl-config... /opt/local/bin/sdl-config checking for SDL - version >= 1.2.4... yes checking for jpeg_CreateDecompress in -ljpeg... yes checking for png_create_read_struct in -lpng... yes checking for uncompress in -lz... yes configure: creating ./config.status config.status: creating Makefile config.status: creating SDL_image.spec config.status: creating SDL_image.qpg config.status: executing depfiles commands Warning: trace revealed an undeclared dependency on jpeg Warning: trace revealed an undeclared dependency on libpng Warning: trace revealed an undeclared dependency on libsdl Warning: trace revealed an undeclared dependency on zlib

[ben@assam dports] $ more devel/libsdl_image/Portfile # $Id: Portfile,v 1.12 2005/07/27 16:50:17 ben Exp $

PortSystem 1.0 name libsdl_image version 1.2.4 revision 5 categories devel graphics maintainers ben@… description Add on library for libSDL handling several image formats long_description This is a simple library to load images of various \

formats as SDL surfaces. This library supports BMP, \ PPM, PCX, GIF, JPEG, PNG, TGA, and TIFF formats.

platforms darwin master_sites http://www.libsdl.org/projects/SDL_image/release/ homepage http://www.libsdl.org/ distname SDL_image-${version} checksums md5 70bf617f99e51a2c94550fc79d542f0b depends_lib bin:sdl-config:libsdl \

lib:libpng:libpng \ lib:libjpeg:jpeg

comment:6 Changed 19 years ago by pguyot (Paul Guyot)

OK. I can reproduce the problem with libsdl_images. Let's split the bug to handle the fact that -t looks at the index and not at the actual variants (I think I will have to rework the whole dependency engine there).

comment:7 Changed 19 years ago by pguyot (Paul Guyot)

Resolution: fixed
Status: assignedclosed

Fixed & Committed!

comment:8 Changed 19 years ago by pguyot (Paul Guyot)

Thanks a lot, Ben, this was a perfect test case.

Here is what I get now:

configure: creating ./config.status config.status: creating Makefile config.status: creating SDL_image.spec config.status: creating SDL_image.qpg config.status: executing depfiles commands Warning: trace revealed an undeclared dependency on zlib [10:08]/<3>darwinports/base(25)>

:)

Note: See TracTickets for help on using tickets.