Opened 11 years ago
Closed 11 years ago
#43585 closed defect (fixed)
terra @ 0.7 use MacPorts defaults for compiler and options
| Reported by: | lockhart (Thomas Lockhart) | Owned by: | pixilla (Bradley Giesbrecht) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.2.1 |
| Keywords: | haspatch, maintainer | Cc: | ryandesign (Ryan Carsten Schmidt) |
| Port: | terra |
Description
This updated Portfile and restructured patch files use compilers and options from the MacPorts configure.cc, configure.cxx, and configure.optflags settings. Patch files are renamed to the MacPorts standard as indicated by "port lint --nitpick". The original patch file "terra.patches" is no longer used and can be deleted. Per feedback from Ryan and Bradley.
Attachments (3)
Change History (8)
Changed 11 years ago by lockhart (Thomas Lockhart)
| Attachment: | Portfile.diff added |
|---|
Changed 11 years ago by lockhart (Thomas Lockhart)
| Attachment: | patch-compiler.diff added |
|---|
Patches to update code for modern compilers.
Changed 11 years ago by lockhart (Thomas Lockhart)
| Attachment: | patch-opengl.diff added |
|---|
Patches to enable window resizing.
comment:1 Changed 11 years ago by pixilla (Bradley Giesbrecht)
| Cc: | pixilla@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to pixilla@… |
My initial commit did not include the correct files. Fixes (including Ryans) will be committed shortly.
comment:2 follow-up: 3 Changed 11 years ago by pixilla (Bradley Giesbrecht)
Tom: Ryan: Does r119779 implement the corrections properly?
comment:3 follow-up: 4 Changed 11 years ago by lockhart (Thomas Lockhart)
Replying to pixilla@…:
Tom: Ryan: Does r119779 implement the corrections properly?
Looks fine to me. I left in the patching on the Makefile but then replaced some of the results with reinplace substitutions per Ryan. I think that should be OK, and keeping the patches acts as a marker for all of the places which need to be updated in that file.
comment:4 Changed 11 years ago by pixilla (Bradley Giesbrecht)
Replying to tlockhart1976@…:
Replying to pixilla@…:
Tom: Ryan: Does r119779 implement the corrections properly?
Looks fine to me. I left in the patching on the Makefile but then replaced some of the results with reinplace substitutions per Ryan. I think that should be OK, and keeping the patches acts as a marker for all of the places which need to be updated in that file.
I like to know when a file changes enough to cause a patch to fail rather then have reinplace simply miss and the build continue.
comment:5 Changed 11 years ago by pixilla (Bradley Giesbrecht)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
See r119779
Patch to use configure variables for compilers and options. Use refactored patch files.