Opened 11 years ago

Closed 11 years ago

#43663 closed defect (fixed)

wavpack: fix pkgconfig file.

Reported by: Ionic (Mihai Moldovan) Owned by: rmstonecipher@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: wavpack

Description

Include ${exec_prefix}, which is used within ${libdir} due to variable expansion.

Attachments (2)

wavpack-pkgconfig.diff​ (1002 bytes) - added by Ionic (Mihai Moldovan) 11 years ago.
Add exec_prefix in wavpack.pc.in.
wavpack-whitespace.diff​ (2.5 KB) - added by Ionic (Mihai Moldovan) 11 years ago.
Whitespace changes only. Applies after wavpack-pkgconfig.diff.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: rmstonecipher@… removed
Owner: changed from macports-tickets@… to rmstonecipher@…

Thanks. Your patch also makes whitespace changes; we'd want to make whitespace changes in a separate commit, so that functional changes are easier to spot.

comment:2 Changed 11 years ago by dbevans (David B. Evans)

Note that the pkgconfig file was fixed in r119897 and ports relying on pkgconfig to detect wavpack were revbumped/updated (r119898, r119912) to take advantage of the change with the exception of sox which apparently doesn't use pkgconfig and xmms2 which is currently broken.

Changed 11 years ago by Ionic (Mihai Moldovan)

Attachment: wavpack-pkgconfig.diff​ added

Add exec_prefix in wavpack.pc.in.

Changed 11 years ago by Ionic (Mihai Moldovan)

Attachment: wavpack-whitespace.diff​ added

Whitespace changes only. Applies after wavpack-pkgconfig.diff.

comment:3 Changed 11 years ago by Ionic (Mihai Moldovan)

I should have synced today... Thanks, devans.

Please invalidate this.

(Unless of course you want to apply the whitespace patch, which should apply cleanly against your patched wavpack portfile.)

Last edited 11 years ago by Ionic (Mihai Moldovan) (previous) (diff)

comment:4 Changed 11 years ago by dbevans (David B. Evans)

Whitespace fixed in r119926. Thanks.

comment:5 Changed 11 years ago by dbevans (David B. Evans)

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.