Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#43667 closed defect (fixed)

py-ipython: +notebook should depend on pandoc to support exporting notebooks as HTML

Reported by: lpsinger (Leo Singer) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: Cc:
Port: py-ipython

Description

IPython Notebook depends on pandoc for exporting notebooks as HTML or other formats:

http://ipython.org/ipython-doc/stable/install/install.html#dependencies-for-nbconvert-converting-notebooks-to-various-formats

The attached patch adds pandoc to depends_run.

Attachments (1)

patch-Portfile.diff (912 bytes) - added by lpsinger (Leo Singer) 11 years ago.
Proposed change to Portfile

Download all attachments as: .zip

Change History (14)

Changed 11 years ago by lpsinger (Leo Singer)

Attachment: patch-Portfile.diff added

Proposed change to Portfile

comment:1 Changed 10 years ago by lpsinger (Leo Singer)

The only downside is that pandoc itself adds 29 dependencies (mostly Haskell libraries). Is that OK?

comment:2 in reply to:  1 ; Changed 10 years ago by seanfarley (Sean Farley)

Replying to aronnax@…:

The only downside is that pandoc itself adds 29 dependencies (mostly Haskell libraries). Is that OK?

I don't see why this has to be a runtime dependency. In the link you posted, ipython docs acknowledge that it's not a dependency and suggest installing pandoc via a package manager.

comment:3 in reply to:  2 ; Changed 10 years ago by lpsinger (Leo Singer)

Replying to sean@…:

Replying to aronnax@…:

The only downside is that pandoc itself adds 29 dependencies (mostly Haskell libraries). Is that OK?

I don't see why this has to be a runtime dependency. In the link you posted, ipython docs acknowledge that it's not a dependency and suggest installing pandoc via a package manager.

Yes, it's optional. This way, the user would not have to research how to obtain pandoc.

comment:4 Changed 10 years ago by mf2k (Frank Schima)

Owner: changed from akitada@… to macports-tickets@…

This port is no longer maintained. See #43692.

comment:5 Changed 10 years ago by mf2k (Frank Schima)

@aronnax: Sounds reasonable to me. Go ahead and commit your patch.

comment:6 in reply to:  5 Changed 10 years ago by lpsinger (Leo Singer)

Resolution: fixed
Status: newclosed

Replying to mf2k@…:

@aronnax: Sounds reasonable to me. Go ahead and commit your patch.

Thank you. Fixed in r121665.

comment:7 in reply to:  3 Changed 10 years ago by dixiao@…

Replying to aronnax@…:

Yes, it's optional. This way, the user would not have to research how to obtain pandoc.

Without pandoc dependency, `port rdeps py34-ipython +notebook' yields 22 dependencies. With pandoc, the number of dependencies shoots up to 112!

I don't think an average user expects to see 112 dependencies when all he/she wants is to install ipython. This change is completely unnecessary, and is precisely what drives users from macports to homebrew.

comment:8 Changed 10 years ago by lpsinger (Leo Singer)

I'm sorry if I acted prematurely. mf2k's imperative tone led me to think that the discussion was closed.

I'm looking at the corresponding Debian package, which lists pandoc as a 'Suggests:' dependency. The closest approximation to this that we could do with MacPorts is add a notes entry to the variant. Would that satisfy everyone?

comment:9 Changed 10 years ago by seanfarley (Sean Farley)

Yes, I am in favor of just the suggestion from notes and keeping the dependencies down. aronnax, do you want to co-maintain this port with me?

comment:10 in reply to:  9 ; Changed 10 years ago by lpsinger (Leo Singer)

Replying to sean@…:

Yes, I am in favor of just the suggestion from notes and keeping the dependencies down.

OK, fixed in r121677.

aronnax, do you want to co-maintain this port with me?

Sure. Would you like to be the first or the second maintainer?

comment:11 in reply to:  10 ; Changed 10 years ago by seanfarley (Sean Farley)

Replying to aronnax@…:

Replying to sean@…:

Yes, I am in favor of just the suggestion from notes and keeping the dependencies down.

OK, fixed in r121677.

Sweet, thanks!

aronnax, do you want to co-maintain this port with me?

Sure. Would you like to be the first or the second maintainer?

Second is fine with me unless you have an objection.

comment:12 in reply to:  11 Changed 10 years ago by lpsinger (Leo Singer)

Replying to sean@…:

Second is fine with me unless you have an objection.

My only objection is due to laziness. We adopted the port in r121678.

comment:13 in reply to:  10 Changed 10 years ago by dixiao@…

Replying to aronnax@…:

Replying to sean@…:

Yes, I am in favor of just the suggestion from notes and keeping the dependencies down.

OK, fixed in r121677.

Thank you.

aronnax, do you want to co-maintain this port with me?

Sure. Would you like to be the first or the second maintainer?

And you are much appreciated for maintaining this port.

Note: See TracTickets for help on using tickets.