perl5 1.0 portgroup cannot handle version numbers with characters

[mf2k (Frank Schima)]

The perl5 1.0 portgroup has a bug where it cannot handle a version number with non-numeric characters in it. See the p5-sgmlspm port as an example. The version it produced was:

  p5.16-sgmlspm @1.3.{}_0 (active)

The issue exists in proc perl5_convert_version.

[ryandesign (Ryan Carsten Schmidt)]

I guess the reason for this is that perl module version numbers are not supposed to have non-numeric characters in them. The author of the affected perl module should be advised of this.

[danielluke (Daniel J. Luke)]

Replying to ryandesign@…:

I guess the reason for this is that perl module version numbers are not supposed to have non-numeric characters in them. The author of the affected perl module should be advised of this.

Looks like the last update to that module on CPAN is from 1995, so it seems unlikely that it will get updated/fixed.

[pixilla (Bradley Giesbrecht)]

I wrote this patch a while back, seems to work ok.

$ port -q installed p5.16-sgmlspm
  p5.16-sgmlspm @1.30.0ii_1 (active)

[mf2k (Frank Schima)]

Unfortunately, I do not think that version number is correct for p5-sgmlspm. According to ​that port's homepage, the version is "1.03ii". In the p5-sgmlspm Portfile, I manually set it to "1.03ii.0".

[jmroot (Joshua Root)]

Yeah, this isn’t really a bug, the version number is invalid. Perl rejects it:

% perl -Mversion -e 'print version->parse("1.03ii")->normal'
Invalid version format (non-numeric data) at -e line 1.

I’d suggest just setting your own version in such cases.