wcslib: fix library install_name

[ryandesign (Ryan Carsten Schmidt)]

The install_name of libwcs.${version}.dylib is wrong (isn't set at build time):

$ port installed wcslib
The following ports are currently installed:
  wcslib @4.23_0 (active)
$ otool -L /opt/local/lib/libwcs.4.23.dylib
/opt/local/lib/libwcs.4.23.dylib:
	libwcs.4.23.dylib (compatibility version 4.0.0, current version 4.23.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1197.1.1)

The port's optional gcc variants try to deal with this problem with this block:

    post-destroot {
        system "install_name_tool -change libwcs.${version}.dylib ${prefix}/lib/libwcs.${version}.dylib ${destroot}${prefix}/lib/libpgsbox.${version}.dylib"
    }

But the better way to deal with this is to set the install_name of libwcs.${version}.dylib at build time.

[john@…]

The attached should address both this issue and #43765.

[ryandesign (Ryan Carsten Schmidt)]

Thanks. I was hoping there would be a variable that could be accessed from the configure script to get the library directory ($libdir?), to avoid having to reinplace the prefix.

[john@…]

That better?

[ryandesign (Ryan Carsten Schmidt)]

Oh, well I looked into it too, and $libdir should be $exec_prefix/lib, which means you shouldn't need to put $prefix in front of it, but the configure script doesn't expand the variable, and $exec_prefix isn't defined in the Makefile. Really, this needs to be reported to the developers for a correct fix.

[john@…]

Indeed, I discovered similar: I initially used ${libdir} before realising it didn't work and using the reinplace you (reasonably enough) objected to above.

Happy to take this to upstream, but, if my latest fix works for you, can we commit that to ensure we're shipping a working library at least in the short term?

[ryandesign (Ryan Carsten Schmidt)]

Committed a fix in r120292. I used a fix that didn't need reinplace, and also used $SONAME instead of $SHRLIB. Please do notify upstream of the problem so they can fix it properly.