Opened 11 years ago
Closed 11 years ago
#43791 closed defect (fixed)
grsync: intltool configuration fails if perl5 variant is not default, post-activate actions
| Reported by: | dbevans (David B. Evans) | Owned by: | Schamschula (Marius Schamschula) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ||
| Port: | grsync |
Description
Newly submitted port grsync fails during intltool configuration if perl5 is installed with a non-default variant (not +perl5_16). To reproduce
$ sudo port install perl5 +perl5_12 $ sudo port -d configure grsync ... checking whether NLS is requested... yes checking for intltool-update... /opt/local/bin/intltool-update checking for intltool-merge... /opt/local/bin/intltool-merge checking for intltool-extract... /opt/local/bin/intltool-extract checking for xgettext... /opt/local/bin/xgettext checking for msgmerge... /opt/local/bin/msgmerge checking for msgfmt... /opt/local/bin/msgfmt checking for gmsgfmt... /opt/local/bin/msgfmt checking for perl... /opt/local/bin/perl checking for perl >= 5.8.1... 5.12.5 checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool Command failed: cd "/opt/local/var/macports/build/_opt_macports_trunk_dports_net_grsync/grsync/work/grsync-1.2.4" && ./configure --prefix=/opt/local --disable-unity Exit code: 2 Error: Failed to configure grsync, consult /opt/local/var/macports/build/_opt_macports_trunk_dports_net_grsync/grsync/work/grsync-1.2.4/config.log Error: org.macports.configure for port grsync returned: configure failure: command execution failed
In addition, the port installs a .desktop file and hicolor icons which require post-activate actions for proper installation.
The attached patch uses autoreconf to recreate configure using the MacPorts version of intltool.m4 which will fix the failure above. In addition a post-activate phase is added which updates the desktop file database and the hicolor icon cache to include the files added by this port. A dependency on desktop-file-utils is added which provides the necessary utility update-desktop-database.
Let me know if you want me to commit these changes. You might also consider adding openmaintainer as well as yourself to the maintainer line so that other maintainers can commit minor changes in your absence.
Attachments (1)
Change History (4)
Changed 11 years ago by dbevans (David B. Evans)
| Attachment: | patch-grsync.diff added |
|---|
comment:1 follow-up: 2 Changed 11 years ago by Schamschula (Marius Schamschula)
Looks good.
Sometimes things magically work: I my case intltool was built against per5.16...
Don't forget to bump the revision!
Marius
comment:2 Changed 11 years ago by dbevans (David B. Evans)
Replying to mschamschula@…:
Looks good.
Sometimes things magically work: I my case intltool was built against per5.16...
Don't forget to bump the revision!
Marius
Yes, it's not a problem for the current default case, but there were many tickets when the default was switched from perl5 +perl5_12 to perl5 +perl5_16.
comment:3 Changed 11 years ago by dbevans (David B. Evans)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Committed in r120314 including revbump and openmaintainer.
Proposed patch to grsync Portfile