Opened 10 years ago

Closed 10 years ago

#43818 closed enhancement (fixed)

log2timeline improvements: sha256, bin symlink

Reported by: jul_bsd@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: log2timeline

Description

  • sha256
  • symlink in bin for main perl executable

Attachments (2)

patch-log2timeline-Portfile.diff (1.4 KB) - added by jul_bsd@… 10 years ago.
log2timeline-ryandesign.diff (2.0 KB) - added by ryandesign (Ryan Carsten Schmidt) 10 years ago.
proposed patch

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

If you change the files the port installs, the revision has to be increased.

comment:2 Changed 10 years ago by jul_bsd@…

Sorry. just forgotten. here.

Changed 10 years ago by jul_bsd@…

comment:3 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

comment:4 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

The symlink is wrong; it should be to ${prefix}/libexec/perl${perl5.version}/sitebin/log2timeline not ${prefix}/libexec/${perl5.version}/sitebin/log2timeline .

Do we still need the following notes?

  tool is /opt/local/libexec/perl5.16/sitebin/log2timeline

Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

proposed patch

comment:5 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Actually we may as well use ${perl5.bindir}; see my counterproposal, attached.

comment:6 Changed 10 years ago by jul_bsd@…

yes. that's it. I did just the same when observing the symlink was wrong. Thanks Ryan!

comment:7 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.