Opened 10 years ago
Closed 10 years ago
#43964 closed enhancement (fixed)
weechat @0.4.3 - subports
Reported by: | harciga | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.0 |
Keywords: | haspatch maintainer | Cc: | |
Port: | weechat |
Description
This patch provides two subports for weechat, weechat-devel
which sits at version git-20140608 and weechat-git
which retrives the latest commit from the official git repo https://github.com/weechat/weechat.git
It also moves the -DCA_FILE argument to the tls variant, as well as the certsync
run dependency
Attachments (3)
Change History (9)
Changed 10 years ago by harciga
Attachment: | Portfile-weechat.diff added |
---|
comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Changed 10 years ago by harciga
Attachment: | Portfile-weechat.2.diff added |
---|
comment:2 follow-up: 3 Changed 10 years ago by harciga
The Portfile now makes use of the github
portgroup.
I'm aware there are no ports that build from the current VCS state, I've written a warning in pre-configure
with ui_msg for that purpose. I'd like to support the -git
subport because some people in #weechat requested it and unless I actively look after commit privileges it seems that even the -devel
subport can't be handled in a timely fashion, as it usually takes over a week to get a ticket closed.
Perhaps I misunderstood your subtle
I do not think we would want to add a weechat-git subport.
If that's the case let me know so I'll remove it from the Portfile.
comment:3 follow-up: 4 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to starkhalo@…:
I'm aware there are no ports that build from the current VCS state, I've written a warning in
pre-configure
with ui_msg for that purpose. I'd like to support the-git
subport because some people in #weechat requested it and unless I actively look after commit privileges it seems that even the-devel
subport can't be handled in a timely fashion, as it usually takes over a week to get a ticket closed.
Since this question comes up from time to time, I've now written up our position on this matter in our wiki.
comment:4 Changed 10 years ago by harciga
Replying to ryandesign@…: Thanks for the clarification Ryan. I have attached the updated Portfile with the appropriate changes.
Replying to starkhalo@…:
I'm aware there are no ports that build from the current VCS state, I've written a warning in
pre-configure
with ui_msg for that purpose. I'd like to support the-git
subport because some people in #weechat requested it and unless I actively look after commit privileges it seems that even the-devel
subport can't be handled in a timely fashion, as it usually takes over a week to get a ticket closed.Since this question comes up from time to time, I've now written up our position on this matter in our wiki.
Changed 10 years ago by harciga
Attachment: | Portfile-weechat.3.diff added |
---|
comment:5 Changed 10 years ago by harciga
This ticket has been superseded by Ticket #44672. Please disregard.
comment:6 Changed 10 years ago by neverpanic (Clemens Lang)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Could the weechat-devel subport use the github portgroup, and fetch from a distfile instead of getting the files from the git repository? If so, that would be preferable. Consult the comments in the github portgroup file for more information.
I do not think we would want to add a weechat-git subport. We want ports to build reproducibly -- the same every time; the weechat-git subport's purpose seems to be to circumvent that by letting it use whatever version happens to be current at the time the install command is run.