Opened 10 years ago

Closed 10 years ago

#44030 closed update (fixed)

Update linkchecker to 9.2

Reported by: kurthindenburg (Kurt Hindenburg) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.0
Keywords: haspatch Cc:
Port: linkchecker

Description

The latest version is 9.2 - it compiles on Mavericks

It requires at least python 2.7 - though I'm not sure if forcing py27 is the way to do this.

I'd like to add a +noqui so it doesn't pull in the huge pyQt4

Attachments (1)

linkchecker.diff (2.3 KB) - added by kurthindenburg (Kurt Hindenburg) 10 years ago.
Adds +gui variant

Download all attachments as: .zip

Change History (4)

comment:1 in reply to:  description Changed 10 years ago by dbevans (David B. Evans)

Replying to khindenburg@…:

I'd like to add a +noqui so it doesn't pull in the huge pyQt4

The preferred way to do this is to configure the port to build without GUI, then add a +gui variant which enables the GUI and make it a default variant. People (like yourself) who don't want the GUI baggage can then use -gui to disable it.

Last edited 10 years ago by dbevans (David B. Evans) (previous) (diff)

Changed 10 years ago by kurthindenburg (Kurt Hindenburg)

Attachment: linkchecker.diff added

Adds +gui variant

comment:2 Changed 10 years ago by dbevans (David B. Evans)

Just removing a dependency is not a reliable way to disable the GUI because you can't guarantee that some other port has not installed it already. So you need to disable the GUI independently of the dependency using a configure option or if that is not available, maybe a patch. If this is not practical you may just have to live with the the GUI and its dependency. You want the port to build the same way for everyone, independent of what other ports may be installed.

Concerning using the github PortGroup, assuming that you have specified your tag properly in github.setup, you do not need to specify master_sites. The PortGroup will configure things automatically to download directly from github. Similarly, this should handle livecheck without any additional commands. If this isn't working, check to make sure you have the right arguments to github.setup. If github doesn't have the version you want, there's no point in using the PortGroup at all.

comment:3 Changed 10 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

Thanks - I'll have to work on the variant later - since the current version doesn't work I'll commit this upgrade - 121100

https://trac.macports.org/ticket/41251

Note: See TracTickets for help on using tickets.