nip2 updated to 7.38.3

[Schamschula (Marius Schamschula)]

nip2 has been updated to @7.38.3. This version builds cleanly under Mavericks, thus also closes #41174

[Schamschula (Marius Schamschula)]

Thanks John!

I had forgotten about the goffice to goffice08 dependency update. Also cleaned up a few more spaces.

[ryandesign (Ryan Carsten Schmidt)]

Your patch makes both whitespace changes and functional changes, which makes the functional changes difficult to spot. We would like to have those two separate things as two separate diffs so they can be committed separately.

Also—out of curiosity, because this situation seems to arise often and I don't understand why it arises—why didn't you attach your patch to the existing ticket #41174? Why did you open a duplicate ticket? If your intention is to give visibility to a ticket that seems to have been forgotten, then the correct procedure is to write to the macports-dev mailing list and remind us to look at the original ticket, not file a duplicate.

[Schamschula (Marius Schamschula)]

Replying to ryandesign@…:

Your patch makes both whitespace changes and functional changes, which makes the functional changes difficult to spot. We would like to have those two separate things as two separate diffs so they can be committed separately.

Also—out of curiosity, because this situation seems to arise often and I don't understand why it arises—why didn't you attach your patch to the existing ticket #41174? Why did you open a duplicate ticket? If your intention is to give visibility to a ticket that seems to have been forgotten, then the correct procedure is to write to the macports-dev mailing list and remind us to look at the original ticket, not file a duplicate.

Ryan,

I get your point about separating whitespace clean-up from functional changes. I'll do that in future updates.

The reason I opened a new ticket is that #41174 referred to nip2 7.26.3, and there have been 23 releases of nip2 since that time.

[jcupitt (John Cupitt)]

patch to update from the current portfile to 7.38.4

[jcupitt (John Cupitt)]

Here's a new patch to update from the current portfile to 7.38.4.

7.38.4 fixes a problem on Mav with memccpy() on overlapping blocks, see #41174.

Thanks for working on this mschamschula.

[kurthindenburg (Kurt Hindenburg)]

Cc Me!

[kurthindenburg (Kurt Hindenburg)]

Looks good here - did you want me to commit this and closes these tickets?

Also, do you get this when you run nip2 from a terminal?

(nip2:49561): Gtk-WARNING **: Error loading icon from file '/opt/local/share/nip2/data/vips-128.png':
        Couldn't recognize the image file format for file '/opt/local/share/nip2/data/vips-128.png'

[jcupitt (John Cupitt)]

No, it runs cleanly for me.

It sounds like gtk has somehow been built without PNG load support, I don't know how that could happen.

edit: I used xquartz, installed macports, and typed "port install nip2", if that could make a difference.

I would commit the change and close the two tickets, it's a big improvement on the current state of things. We can resolve the png load failure in a new ticket.

[Schamschula (Marius Schamschula)]

Works for me.

No issues with png files.

[Schamschula (Marius Schamschula)]

nip2 has been updated upstream to version 7.40.1. I've updated the Portfile-nip2.diff file accordingly.

[Schamschula (Marius Schamschula)]

In the meantime nip2 has been bumped to vesion 7.40.2…

Ooops: added a diff file w/o removing the revision number.

[ryandesign (Ryan Carsten Schmidt)]

r121747