Opened 10 years ago
Last modified 10 years ago
#44090 closed update
nip2 updated to 7.38.3 — at Version 2
Reported by: | Schamschula (Marius Schamschula) | Owned by: | jcupitt@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.0 |
Keywords: | haspatch | Cc: | ryandesign@… |
Port: | nip2 |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
nip2 has been updated to @7.38.3. This version builds cleanly under Mavericks, thus also closes #41174
Change History (2)
comment:1 Changed 10 years ago by Schamschula (Marius Schamschula)
comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign@… added; jcupitt@… removed |
---|---|
Description: | modified (diff) |
Keywords: | haspatch added |
Owner: | changed from macports-tickets@… to jcupitt@… |
Your patch makes both whitespace changes and functional changes, which makes the functional changes difficult to spot. We would like to have those two separate things as two separate diffs so they can be committed separately.
Also—out of curiosity, because this situation seems to arise often and I don't understand why it arises—why didn't you attach your patch to the existing ticket #41174? Why did you open a duplicate ticket? If your intention is to give visibility to a ticket that seems to have been forgotten, then the correct procedure is to write to the macports-dev mailing list and remind us to look at the original ticket, not file a duplicate.
Thanks John!
I had forgotten about the goffice to goffice08 dependency update. Also cleaned up a few more spaces.