Opened 10 years ago
Closed 10 years ago
#44102 closed submission (invalid)
new portfile of peco
Reported by: | noname@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.0 |
Keywords: | Cc: | kurthindenburg (Kurt Hindenburg) | |
Port: |
Description
i made new portfile of peco
Attachments (2)
Change History (8)
Changed 10 years ago by noname@…
comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Thanks. Some initial observations:
- the github portgroup and its "
github.setup
" procedure should be used, which will eliminate many lines (name, version, master_sites, distname, worksrcdir, livecheck.*) from the portfile - more than one checksum type should be used; typically, we want to use rmd160 and sha256 checksum types
- there's no need to "
file mkdir ${destroot}/${prefix}/bin
"; MacPorts makes this and other standard directories for you - there should be no slash before "
${prefix}
" because "${prefix}
" already begins with a slash
comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Oh and:
- the maintainer email address should be obfuscated in our host:user format
comment:3 Changed 10 years ago by noname@…
thanks feedback.
fixed some problems.
https://github.com/withgod/portfile-peco/commit/f0b199ff34e7b2229c2826e865943f0a49fbc87d
you say "eliminate many lines(name" but many Portfile contain name.
kept name line.
Changed 10 years ago by noname@…
Attachment: | Portfile.2 added |
---|
comment:4 Changed 10 years ago by noname@…
version dump, follow repository moved.
https://github.com/withgod/portfile-peco
and i found other mac ports package ;(
https://trac.macports.org/browser/trunk/dports/sysutils/peco/Portfile?rev=121692
comment:6 Changed 10 years ago by kurthindenburg (Kurt Hindenburg)
Resolution: | → invalid |
---|---|
Status: | new → closed |
I'll go ahead and close this as peco is already in w/ a latter version.
Note: See
TracTickets for help on using
tickets.
Portfile