Opened 10 years ago
Closed 10 years ago
#44167 closed submission (fixed)
cot 1.0.0
Reported by: | glenn@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | ||
Port: | cot |
Description
COT (the Common OVF Tool) is a tool for editing Open Virtualization Format (.ovf, .ova) virtual appliances, with a focus on virtualized network appliances such as the Cisco CSR 1000V and Cisco IOS XRv platforms.
Attachments (1)
Change History (13)
comment:1 Changed 10 years ago by glenn@…
comment:2 follow-up: 3 Changed 10 years ago by mf2k (Frank Schima)
Comment: Since you are using the python and github portgroups, you must use depends_lib-append
instead of depends_lib
to not override dependencies of those portgroups.
comment:3 Changed 10 years ago by glenn@…
Replying to mf2k@…:
Comment: Since you are using the python and github portgroups, you must use
depends_lib-append
instead ofdepends_lib
to not override dependencies of those portgroups.
Updated. Thanks!
comment:4 follow-up: 5 Changed 10 years ago by mf2k (Frank Schima)
Version: | 2.3.1 |
---|
I'm not understanding the use of the python portgroup here - or it is being used incorrectly. Is this supposed to be a python module? The port comes out as "cot" and not "py27-cot" and "py33-cot". If it is, then the categories are incorrect. It should be:
categories-append sysutils emulators
Because python should be first and is included with the python portgroup. Also the following line should be added beneath the github.setup
line:
name py-cot
Also the line python.default_version 27
can be deleted since that is the default.
Finally, the dependencies must be placed inside of a if {${name} ne ${subport}} {
block.
comment:5 Changed 10 years ago by glenn@…
Replying to mf2k@…:
I'm not understanding the use of the python portgroup here - or it is being used incorrectly. Is this supposed to be a python module? The port comes out as "cot" and not "py27-cot" and "py33-cot".
This is primarily an application - although it consists of a set of modules which could conceivably be integrated into other applications as well. So I think "cot" is correct, based on my reading of the docs:
If the port name does not start with “py-”, it is interpreted as an application written in python rather than a python module. In this case, no subports are defined...
That said this is the first time I've used the python portgroup, so if my usage is incorrect, I apologize!
If it is, then the categories are incorrect. It should be:
categories-append sysutils emulatorsBecause python should be first and is included with the python portgroup.
OK, will fix this.
Also the following line should be added beneath the
github.setup
line:name py-cot
As above - I don't think this is desirable.
Also the line
python.default_version 27
can be deleted since that is the default.
Per the docs, this must be set for an application:
For apps (i.e. name does not start with “py-”), this chooses which version of python to use, and must be set. It can be changed in variants if desired.
Finally, the dependencies must be placed inside of a
if {${name} ne ${subport}} {
block.
Since this is an app, it doesn't have subports, right?
comment:6 Changed 10 years ago by mf2k (Frank Schima)
It is fine to be named "cot" and not have py*- subports and only use python 2.7. But your usage of python.versions 27 33
is confusing since python 3.3 is not involved here. So the 33 needs to be removed.
comment:7 Changed 10 years ago by glenn@…
My reasoning was that COT can be installed and run against either 2.7 or 3.3. Is there a better way to indicate this in the Portfile?
Thanks.
comment:12 Changed 10 years ago by mf2k (Frank Schima)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Added in r123908 with the following changes:
- Changed
categories-append
tocategories
to remove python from the primary category. - Added required build dependency on py-setuptools.
Hi, is there anything I can do to help move this along?