Opened 10 years ago
Closed 4 years ago
#44172 closed defect (invalid)
libffi: missing build dependencies
| Reported by: | Ionic (Mihai Moldovan) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Low | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | petrrr, cooljeanius (Eric Gallager) | |
| Port: | libffi |
Description
libffi would like to have the following build dependencies:
port:autoconfport:automakeport:grepport:texinfoport:cctools
I'll provide a patch.
Change History (7)
comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 Changed 10 years ago by Ionic (Mihai Moldovan)
No, it doesn't fail.
Let's hold on on this until I get some feedback on the dev mailing list regarding the right way to deal with those things.
comment:5 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
So what's the word here?
How did you determine that the above listed dependencies were needed?
comment:6 Changed 10 years ago by Ionic (Mihai Moldovan)
I have "determined" those dependencies by building libffi in trace mode.
Those are the violations that popped up.
Even though libffi built fine even without them, some of them may better be added to make it happy/not lose functionality in trace mode.
I guess port:autoconf and port:automake should be added as build dependencies.
gsed, coreutils, grep and cctools are redundant (the system-provided tools will work just fine.)
I probably have to take a closer look at how exactly autoconf, automake and texinfo are being used during the build process exactly and decide once I know more.
comment:7 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
I'm guessing we don't need to do anything here. Not everything that trace mode reports requires a portfile change.
As you say, gsed, coreutils, grep, and cctools (and texinfo probably) don't need to be added as dependencies. If installed, the MacPorts versions will be used, otherwise the system versions will be used, and either is usually fine.
If the port needs autoconf and automake they need to be declared. I didn't go back to look at what the situation was 7 years ago when this ticket was filed, but today, the port runs autoreconf (and MacPorts base automatically adds the needed dependencies to do that) only on Big Sur to support Apple Silicon.
It builds fine for me when those ports are not installed. Could you provide a main.log file showing the problems you encountered when those ports are not installed?