#44273 closed enhancement (fixed)
audacious-plugins: notes format fix.
Reported by: | Ionic (Mihai Moldovan) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch maintainer | Cc: | |
Port: | audacious-plugins |
Description
This changes the notes
block to notes-append
and uses a TCL block
instead of a literal string.
No functional change.
Attachments (2)
Change History (5)
Changed 10 years ago by Ionic (Mihai Moldovan)
Attachment: | audacious-plugins-notes.patch added |
---|
Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Attachment: | audacious-plugins-ryandesign.diff added |
---|
alternative patch
comment:1 follow-up: 3 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
I would be inclined to remove the asterisks because they give the impression that someone thinks these notes are more important than any other port's notes. I would then also be inclined to allow MacPorts to wrap the text to the user's terminal width rather than putting each sentence on a new line. What do you think about my alternative patch?
comment:2 Changed 10 years ago by tobypeterson
Resolution: | → fixed |
---|---|
Status: | new → closed |
Too late, committed r121791
comment:3 Changed 10 years ago by Ionic (Mihai Moldovan)
Replying to ryandesign@…:
I would be inclined to remove the asterisks because they give the impression that someone thinks these notes are more important than any other port's notes.
I've seen other ports doing this sort of thing, that's why I did it initially. I'm totally fine with dropping the asterisks.
I would then also be inclined to allow MacPorts to wrap the text to the user's terminal width rather than putting each sentence on a new line.
That's a bad idea, to my mind. That makes it difficult/uncomfortable to read on terminals with a big width. That's also the reason why website layouts normally don't use the full width but a specific percentage of it -- to increase readability. (Any port with notes I've so far seen shows this behavior, too.)
What do you think about my alternative patch?
Go ahead and remove the asterisks, I'm doing that locally too. If you don't feel like pushing such a trivial change, I'll include it next time there is more to do, maintenance-wise.
Change notes to notes-append and use TCL block.