Opened 10 years ago
Closed 10 years ago
#44285 closed enhancement (fixed)
python-related: switch from py*-pil to path-based dependency (maintained, no openmaintainer)
Reported by: | Ionic (Mihai Moldovan) | Owned by: | rowue@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | mojca (Mojca Miklavec), petrrr, servicegruppe.wissinfo@…, alexander.held@…, stromnov (Andrey Stromnov) |
Port: | py-aplpy py-psychopy py-pyphant |
Description
In accordance with communication on the MP users mailing list, I have changed py*-pil
dependencies to path:
-based ones satisfiable by both py*-pil
and py*-Pillow
.
This patchset is tracking and targeted at maintained non-openmaintainer ports.
Don't commit the patchset without maintainer consent, please. I'll update this ticket as I get responses.
(Not CC'ing maintainers, as I have sent them eMails individually and people don't need to be bothered for other stuff but their own ports.)
Attachments (1)
Change History (23)
comment:1 Changed 10 years ago by mojca (Mojca Miklavec)
Cc: | mojca@… added |
---|
comment:2 follow-up: 4 Changed 10 years ago by mojca (Mojca Miklavec)
Three out of seven ports are about pyphant
. Please see also #40347. I would suggest to "clean up" pyphant
either before or at the same time as committing this change. We could also remove support for python26 which is only there because of py26-wxwidgets-2.8
(to allow side-by-side installation with py27-wxwidgets-3.0
) and wxWidgets 2.8 are no longer required.
comment:3 Changed 10 years ago by Ionic (Mihai Moldovan)
py-SRPAstro | stefano.covino@ | moved | moved to #44308 |
py-aplpy | robitaille@ | accepted | additionally added openmaintainer on request
|
py-psychopy | jameskyle@ | accepted | additionally added openmaintainer on request
|
comment:4 follow-ups: 6 16 Changed 10 years ago by Ionic (Mihai Moldovan)
Replying to mojca@…:
I would suggest to "clean up"
pyphant
either before or at the same time as committing this change.
I'm OK either way. Your updated Portfile
replacing all 6 ports is only requiring a change on line 150 to "path:${python.pkgd}/PIL:py${python.version}-Pillow"
Also, please note that 2 of my differences are only changing comments for pyphant
ports py-pyphant-tools
and py-pyphant-osc
.
We could also remove support for python26 which is only there because of
py26-wxwidgets-2.8
(to allow side-by-side installation withpy27-wxwidgets-3.0
) and wxWidgets 2.8 are no longer required.
My changes do not depend on the python version, as far as it is 2.6 or up. :) Feel free to remove anything.
For python PortGroup
ports, the change is even pretty trivial.
comment:6 Changed 10 years ago by mojca (Mojca Miklavec)
Replying to ionic@…:
Also, please note that 2 of my differences are only changing comments for
pyphant
portspy-pyphant-tools
andpy-pyphant-osc
.
Please note that I didn't even see your patch ;)
comment:7 Changed 10 years ago by Ionic (Mihai Moldovan)
Just regard those changes as non-existent for your pyphant
cleanup.
There's no need to wait for pushing the changes to the (current) 3 pyphant
ports.
I'll attach a patch for your cleaned up Portfile
later today in the other ticket.
comment:8 Changed 10 years ago by Ionic (Mihai Moldovan)
gpodder
will be handled in #44306. Can be removed from this ticket. Patchset will be updated soon.
comment:9 Changed 10 years ago by Ionic (Mihai Moldovan)
py-SRPAstro
will be handled in #44308. Can be removed from this ticket. Patchset will be updated soon.
comment:10 Changed 10 years ago by mf2k (Frank Schima)
Port: | gpodder py-SRPAstro removed |
---|
Changed 10 years ago by Ionic (Mihai Moldovan)
Attachment: | python-pil-pillow-maintainers.diff added |
---|
Switch from py*-pil
to path:
-based dependency satisfiable by both py*-pil
and py*-Pillow
. Add openmaintainer
to py-aplpy
and py-psychopy
on maintainer request. Add Pillow
compat patch to py-psychopy
.
comment:12 Changed 10 years ago by petrrr
py-aplpy
does not install for me, due to dependency py-pyregions
, see #44391;
comment:13 Changed 10 years ago by petrrr
In r122358 I committed the patch for py-aplpy
and py-psychopy
.
I will leave decision on how to further proceed with the py-pyphant-*
related stuff to mojca and the maintainers.
comment:14 Changed 10 years ago by petrrr
Cc: | servicegruppe.wissinfo@… alexander.held@… added |
---|---|
Owner: | changed from macports-tickets@… to rowue@… |
comment:16 follow-up: 19 Changed 10 years ago by alexander.held@…
Replying to ionic@…:
...
Also, please note that 2 of my differences are only changing comments for
pyphant
portspy-pyphant-tools
andpy-pyphant-osc
....
The commented-out dependencies in py-pyphant-tools and py-pyphant-osc are outdated and have been removed. The suggested patch for py-pyphant-imageprocessing will break the port, as PIL is also a dependency on the setuptools level. The runtime plugin mechanism for adding the py-pyphant-imageprocessing toolbox to py-pyphant will fail when it cannot resolve this dependency as it is based on pkg_resources. The Pillow/PIL fallback mechanism would also have to be implemented on the setuptools level. We are working on a solution for py-pyphant-imageprocessing. Any helpful input is welcome. We have also set all pyphant related ports to openmaintainer.
comment:17 Changed 10 years ago by mojca (Mojca Miklavec)
I committed r122639 to merge the pyphant ports. The comment about PIL probably still applies (I didn't even try), so I didn't touch it.
comment:18 Changed 10 years ago by mojca (Mojca Miklavec)
Port: | py-pyphant added; py-pyphant-imageprocessing py-pyphant-osc py-pyphant-tools removed |
---|
comment:19 Changed 10 years ago by Ionic (Mihai Moldovan)
Replying to alexander.held@…:
The commented-out dependencies in py-pyphant-tools and py-pyphant-osc are outdated and have been removed.
Thanks (also to Mojca!) :)
The suggested patch for py-pyphant-imageprocessing will break the port, as PIL is also a dependency on the setuptools level. The runtime plugin mechanism for adding the py-pyphant-imageprocessing toolbox to py-pyphant will fail when it cannot resolve this dependency as it is based on pkg_resources. The Pillow/PIL fallback mechanism would also have to be implemented on the setuptools level. We are working on a solution for py-pyphant-imageprocessing. Any helpful input is welcome. We have also set all pyphant related ports to openmaintainer.
Thanks for checking.
Unfortunately, I cannot provide any help. I've been looking around the setuptools documentation, but couldn't find any mention of multiple dependencies/packages satisfying one dependency. Maybe there is just no such thing in setuptools yet?
comment:20 follow-up: 21 Changed 10 years ago by mojca (Mojca Miklavec)
I would suggest to either rename this ticket or to close it and open a new one devoted just to this single issue (PIL & pyphant). All the other trivial patches have been applied already. Maybe opening a new one is better?
comment:21 Changed 10 years ago by alexander.held@…
Replying to mojca@…:
I would suggest to either rename this ticket or to close it and open a new one devoted just to this single issue (PIL & pyphant). All the other trivial patches have been applied already. Maybe opening a new one is better?
I have opened ticket #44472 regarding py27-pyphant-imageprocessing and PIL/Pillow
comment:22 Changed 10 years ago by mojca (Mojca Miklavec)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Cc Me!