Opened 10 years ago
Closed 10 years ago
#44351 closed defect (fixed)
Fix phonon cmake install
Reported by: | springermac (Jonathan Springer) | Owned by: | michaelld (Michael Dickens) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | mkae (Marko Käning), diochnos |
Port: | phonon |
Description
The PhononConfig.cmake file didn't set the rootDir properly and the PhononTargets-release.cmake file was using the import directory instead of the PHONON_LIBRARY_DIR.
Attachments (1)
Change History (15)
comment:1 Changed 10 years ago by mf2k (Frank Schima)
Cc: | michaelld@… removed |
---|---|
Keywords: | haspatch added |
Owner: | changed from macports-tickets@… to michaelld@… |
comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Changed 10 years ago by springermac (Jonathan Springer)
Attachment: | Portfile-phonon.diff added |
---|
Update portfile with upped revision
comment:3 Changed 10 years ago by mkae (Marko Käning)
Cc: | mk@… added |
---|---|
Version: | 2.3.1 |
comment:4 Changed 10 years ago by mkae (Marko Käning)
This patch is against phonon 4.7.1.
Is it correct that it wouldn't be needed with 4.7.2 as submitted in #44305?
comment:5 Changed 10 years ago by springermac (Jonathan Springer)
No this will still be needed with 4.7.2.
comment:7 Changed 10 years ago by michaelld (Michael Dickens)
How do I test that the resulting "fixed" files are incorrect without this patch, and corrected with it?
comment:8 Changed 10 years ago by springermac (Jonathan Springer)
I fixed this in the process of trying to build the phonon gstreamer backend so trying to build it without this patch should fail and with this patch should succeed.
The only thing is that I would like is to fix this in the cmake files before phonon is built so the generated files are correct instead of trying to patch them after they are made and run the risk of possibly not taking into account a user's setup. I would try and fix the original cmake files but I don't have enough experience with cmake to do that.
comment:9 Changed 10 years ago by michaelld (Michael Dickens)
Can you provide whatever info I need to know to recreate your building of the gstreamer backend, so that I can test/verify the changes? Once I know what to do, I will try to fix in the source. But, without knowing what to do it's a little difficult to fix.
comment:10 Changed 10 years ago by springermac (Jonathan Springer)
See ticket 44350 for the proposed portfile for the phonon-backend-gstreamer port.
comment:11 Changed 10 years ago by michaelld (Michael Dickens)
Got it. Yes, I see the issue now. I'll look into seeing if I can fix it in the phonon source instead of a post-destroot.
comment:14 Changed 10 years ago by michaelld (Michael Dickens)
Resolution: | → fixed |
---|---|
Status: | new → closed |
If this changes files that get installed by the port, then the port's revision must be increased.