arb @6.0: error: unknown type name 'vm_extmod_statistics_data_t'

[ryandesign (Ryan Carsten Schmidt)]

arb 6.0 failed to build on the Lion (10.7) buildslave (with Xcode clang):

In file included from src/globalsosx.cpp:16:
/usr/include/mach/task_info.h:252:2: error: unknown type name 'vm_extmod_statistics_data_t'
        vm_extmod_statistics_data_t             extmod_statistics;
        ^
1 error generated.

[mattcottrell]

I do not currently have access to Mac running Lion (10.7), so I cannot work on this now. If I do get such a machine, I'll see what I can do.

[ryandesign (Ryan Carsten Schmidt)]

After some Googling I think I found the ​same problem fixed in another package by adding this line in the right place:

#include <mach/vm_statistics.h>

[mattcottrell]

I think I've got a patch that will work, but I need help with Portfile syntax.

I think it would be something like this to apply the patchfile only to Lion (10.7):

platform darwin 8 {
patchfiles             patch-ARB-globalsosx.cpp.diff
}

Is that right?

[mattcottrell]

I would upload the patchfile, but I keep getting a Captch Error, so I'm stuck.

Can I please get some help with this Captcha error?

Thanks.

[ryandesign (Ryan Carsten Schmidt)]

Replying to matt.cottrell@…:

I think I've got a patch that will work, but I need help with Portfile syntax.

I think it would be something like this to apply the patchfile only to Lion (10.7):

platform darwin 8 {
patchfiles             patch-ARB-globalsosx.cpp.diff
}

Is that right?

darwin 8 is Mac OS X 10.4. OS X 10.7 would be darwin 11. I'm just surprised you need to apply this patch conditionally on OS X 10.7. I would expect there to be a solution that is safe to apply unconditionally.

[ryandesign (Ryan Carsten Schmidt)]

Also, you would want to append to patchfiles, not overwrite it.

[ryandesign (Ryan Carsten Schmidt)]

Committed in r123099.

[ryandesign (Ryan Carsten Schmidt)]

In bd54759ee22faa4e38c8837af6f8e33b4f7ef8f7/macports-ports (master):

arb: Fix build on Lion again

The previous patch is still needed after all, but can safely be applied
unconditionally.

See: #44368