CrystFEL software suite

[rkirian@…]

Hello, I have not submitted anything before, but I would like to make the software suite CrystFEL available for installation through macports. I have tested the portfile locally on a clean install of macports on Mavericks and it so far has worked fine.

This software suite is for the analysis of x-ray crystallographic diffraction data. It should be under the "science" category. It is GPLv3 licensed. More information can be found here: ​http://www.desy.de/~twhite/crystfel/

[rkirian@…]

CrystFEL port file

[ryandesign (Ryan Carsten Schmidt)]

Thanks. Some observations:

• the license should be "GPL-3" (or possibly "GPL-3+"; I haven't checked). See port lint:

$ port lint
--->  Verifying Portfile for crystfel
Error: invalid license 'GPLv3': missing hyphen before version

• the maintainers line must be your valid email address, in our obfuscated host:user format
• the pango dependency should be written so that pango-devel could satisfy it; see other ports that depend on pango for an example
• pkgconfig and gtk-doc are typically only used at build time and should therefore be depends_build not depends_lib
• for better logging, --disable-silent-rules should be added to configure.args
• the post-destroot block has numerous problems:
  • "file copy" can be more succinctly written as "copy"
  • you're attempting to copy files directly into ${prefix}, bypassing ${destroot}; MacPorts sandboxing prevents this from succeeding; this should cause a permission denied error to be printed and the destroot phase to be interrupted at that point, but that's not happening; I don't understand why
  • if you fix that, then on the preceding line you're pre-creating the directory, which should cause the copy to exit with an error that the directory already exists
  • the Makefile already installs these files in ${prefix}/share/doc/crystfel/scripts; you could move them into ${prefix}/share/examples/crystfel to better conform to portheir(7).

[ryandesign (Ryan Carsten Schmidt)]

Cc Me!

[rkirian@…]

Replying to ryandesign@…:

Cc Me!

Thank you for the many corrections and suggestions. I've done nearly everything suggested, and I removed the unnecessary post-destroot block.

There is one exception: I don't know what to do about pango/pango-devel. I don't even know how to find a listing of Portfiles that depend on pango. I'll start digging into this, but further guidance would be greatly appreciated.

Rick

[larryv (Lawrence Velázquez)]

Replying to rkirian@…:

There is one exception: I don't know what to do about pango/pango-devel. I don't even know how to find a listing of Portfiles that depend on pango. I'll start digging into this, but further guidance would be greatly appreciated.

You can get a workable list with port echo depends:pango.

[rkirian@…]

Replying to larryv@…:

You can get a workable list with port echo depends:pango.

Thank you. Following a few examples, I added path:lib/pkgconfig/pango.pc:pango to depends_lib. The installation appears to be successful.

[rkirian@…]

Second attempt to create a proper Portfile

[ryandesign (Ryan Carsten Schmidt)]

Thanks. Added in r123124 with a few more changes, including fixing the livecheck.