Opened 10 years ago
Closed 4 years ago
#44582 closed update (fixed)
port update: hercules 3.10
Reported by: | benoit.triquet@… | Owned by: | herbygillot (Herby Gillot) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | SickTeddyBear, kurthindenburg (Kurt Hindenburg), nerdling (Jeremy Lavergne) | |
Port: | hercules |
Description
Please find an update of Hercules to version 3.10. 3.07 does not build under Mac OS 10.9 due to setsockopt(..., SOL_TCP, ...) and 3.10 fixes this. "port lint" is clean.
Other changes to the Portfile vs. 3.07:
- maintainer set to nomaintainer because the previous update was 4 years old and the Portfile has been broken for a while now on 10.9
- website clearly states the license is the QPL
- added a conflict with hercules-devel (see other ticket for that new port) - I don't know if each port should exclude the other one or if just hercules-devel should exclude hercules
- removed the depend_libs clause as all the dependencies that were explicit in the previous portfile seem automatically identified according to the build log
- "--enable-optimizations" was renamed to "--enable-optimization"
- i see no reason to disable GUI support as it builds fine
- GCC 4.8 is necessary as Apple's Clang has an issue with long double usage in Hercules
- "universal_build no" does not seem necessary anymore, the default build is not universal anyway
Attachments (2)
Change History (15)
Changed 10 years ago by benoit.triquet@…
comment:1 Changed 10 years ago by benoit.triquet@…
Also note the new website because 3.10 is by a new upstream maintainer.
comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Owner: | changed from macports-tickets@… to jking@… |
---|
Please provide a unified diff of your changes instead of a complete new Portfile.
comment:3 follow-up: 4 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Out of curiosity: why force gcc48?
comment:4 Changed 10 years ago by benoit.triquet@…
Replying to ryandesign@…:
Out of curiosity: why force gcc48?
Sorry that is an unnecessary leftover from my hercules-devel portfile that I did before upgrading the 3.07 hercules portfile to 3.10. 4.00 needs gcc 4.8 because their configure.ac wants to use -m128bit-long-double and clang refuses that switch so it's either gcc48 or patching the configure script but that would have required a further investigation that I did not carry out: does hercules-devel really need 128-bit long doubles and if so, does clang support that with what command line?
The portfile diff no longer has the compiler line.
comment:7 Changed 10 years ago by kurthindenburg (Kurt Hindenburg)
I'm testing 3.11
HHCCF003S Open error file hercules.cnf: No such file or directory
It appears to force having hercules.cnf in the current folder which is fairly terrible.
I'm not sure what "universal_build no" does for this port.
I'll put in ports abandon ticket since it appears all his ports haven't been touched since 2011.
comment:8 Changed 10 years ago by nerdling (Jeremy Lavergne)
Cc: | snc@… added |
---|
A patch for 3.07 was provided on IRC: r134519 and r134520
comment:9 Changed 10 years ago by nerdling (Jeremy Lavergne)
Is it possible to update the patch, expressing the compiler issues based on this chart?
comment:10 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)
does clang support that with what command line
"long double" is 16-byte alligned already. There's no need for a special command line.
comment:11 Changed 7 years ago by mf2k (Frank Schima)
Owner: | jking@… deleted |
---|---|
Status: | new → assigned |
Version: | 2.3.1 |
See #54369.
comment:12 Changed 4 years ago by herbygillot (Herby Gillot)
Proposed PR here: https://github.com/macports/macports-ports/pull/8021
Updates hercules to 3.13
comment:13 Changed 4 years ago by herbygillot (Herby Gillot)
Owner: | set to herbygillot |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
hercules 3.10 portfile