Opened 10 years ago

Closed 10 years ago

#44634 closed defect (fixed)

alpine @2.00_5: build fails with duplicate function declaration

Reported by: schnide (Joe Schnide) Owned by: jcvernaleo (John C. Vernaleo)
Priority: Normal Milestone:
Component: ports Version: 2.3.99
Keywords: yosemite Cc: infostud (Geoff Fellows), SickTeddyBear, glen@…, jcvernaleo (John C. Vernaleo), Russell-Jones-OxPhys (Russell Jones)
Port: alpine

Description

Running DP 5 on MacBook Pro

Please let me know if I can provide further information.

Thanks Joe

see attached for log

Attachments (2)

alpine.txt (438.8 KB) - added by schnide (Joe Schnide) 10 years ago.
alpine build log
alpine-2.00_panic_rename.patch (20.8 KB) - added by greeneg (Gary Greene) 10 years ago.
Rename all uses of panic to uw_panic to work around mach headers scoping issues.

Download all attachments as: .zip

Change History (18)

Changed 10 years ago by schnide (Joe Schnide)

Attachment: alpine.txt added

alpine build log

comment:1 Changed 10 years ago by larryv (Lawrence Velázquez)

Keywords: yosemite added; 10.10 alpine removed
Summary: alpine failing to buildalpine @2.00_5: build fails with duplicate function declaration
:info:build /usr/bin/clang -DHAVE_CONFIG_H   -I../include -I../include -I/opt/local/include -I/opt/local/include -I/opt/local/include -g -D_THREAD_SAFE  -Dbsd -pipe -Os -arch x86_64 -MT ablookup.o -MD -MP -MF .deps/ablookup.Tpo -c -o ablookup.o ablookup.c
:info:build In file included from ablookup.c:20:
:info:build ./../pith/util.h:59:8: error: conflicting types for 'panic'
:info:build void      panic(char *);
:info:build           ^
:info:build /usr/include/mach/mach.h:86:15: note: previous declaration is here
:info:build extern void                     panic(const char *, ...);
:info:build                                 ^
:info:build 1 error generated.

comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

We could rename alpine's panic function so it does not conflict with mach's.

comment:3 Changed 10 years ago by greeneg (Gary Greene)

I've tested a build after doing the proper SnR on the tree to rename panic to uw_panic. Builds fine and runs correctly. Attaching patch for review.

Changed 10 years ago by greeneg (Gary Greene)

Rename all uses of panic to uw_panic to work around mach headers scoping issues.

comment:4 Changed 10 years ago by schnide (Joe Schnide)

How do I go about testing this solution? Thanks.

comment:5 Changed 10 years ago by schnide (Joe Schnide)

Did some research and got the patch in and built fine. No problems. Thanks.

comment:6 Changed 10 years ago by infostud (Geoff Fellows)

Cc: geoff.fellows@… added

Cc Me!

comment:7 Changed 10 years ago by Liontooth (David Liontooth)

This bug is still hitting; could someone please apply the tested and verified patch?

comment:8 Changed 10 years ago by SickTeddyBear

Cc: amcgee@… added

Cc Me!

comment:9 Changed 10 years ago by glen@…

Cc: glen@… added

Cc Me!

comment:10 Changed 10 years ago by jcvernaleo (John C. Vernaleo)

Cc: john@… added

Cc Me!

comment:11 Changed 10 years ago by jcvernaleo (John C. Vernaleo)

I manually applied that patch and alpine builds on Yosemite and alpine builds again. Nice work. Hopefully it can get added in soon.

comment:12 Changed 10 years ago by Russell-Jones-OxPhys (Russell Jones)

Cc: russell.jones@… added

Cc Me!

comment:13 Changed 10 years ago by Liontooth (David Liontooth)

The mail client alpine has been uninstallable for four months because of a variable name conflict. The patch simply replaces "panic" with "uw_panic" --

  sudo port install alpine --without_tcl
  wget https://trac.macports.org/raw-attachment/ticket/44634/alpine-2.00_panic_rename.patch -P /tmp
  cd /opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/mail/alpine/work
  sudo chown -R $USER alpine-2.00
  patch -p0 < /tmp/alpine-2.00_panic_rename.patch
  sudo chown -R macports alpine-2.00
  sudo port install alpine --without_tcl

Could someone please put this bug out of its misery -- the maintainer is not taking care of it and it affects lots of users.

Cheers, David

comment:14 in reply to:  13 Changed 10 years ago by jcvernaleo (John C. Vernaleo)

Does the alpine port have a maintainer even?

If it doesn't, I'm willing to step up and do it. I maintain the alpine port in bitrig (an OpenBSD fork) so I'm pretty familiar with it.

comment:15 Changed 10 years ago by neverpanic (Clemens Lang)

Owner: changed from macports-tickets@… to john@…

Committed in r129886, added new maintainer in r129887, thanks.

comment:16 Changed 10 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.