cpan2port improvements

[mojca (Mojca Miklavec)]

• try to figure out if there is some desired order of keys (perl5.branches/perl5.setup/licence/maintainer/...)
• properly implement if {${perl5.major} != ""} { and put dependencies inside the block
• description is often missing, but META.yml usually contains abstract: that could be used
• sort dependencies alphabetically
• something seems to be wrong with dependencies, see cpan2port -t Mouse for example:

  build_requires:
    Test::Exception: 0
    Test::Exception::LessClever: 0
    Test::Fatal: 0
    Test::LeakTrace: 0
    Test::More: 0.88
    Test::Output: 0
    Test::Requires: 0
    Try::Tiny: 0
  configure_requires:
    CPAN::Meta: 0
    CPAN::Meta::Prereqs: 0
    Devel::PPPort: 3.19
    ExtUtils::ParseXS: 3.22
    Module::Build: 0.4005
    Module::Build::XSUtil: 0
  requires:
    Scalar::Util: 1.14
    XSLoader: 0.02
    perl: 5.008005
  

But it generates:

    depends_build-append \
                    port:p5${perl5.major}-test-exception \
                    port:p5${perl5.major}-test-exception-lessclever \
                    port:p5${perl5.major}-test-fatal \
                    port:p5${perl5.major}-test-leaktrace \
                    port:p5${perl5.major}-test-output \
                    port:p5${perl5.major}-test-requires \
                    port:p5${perl5.major}-try-tiny

In particular Module::Build::XSUtil and everything else from configure_requires is missing, as well as runtime dependencies.

[mojca (Mojca Miklavec)]

some patches addressing alignment of dependencies only

[pixilla (Bradley Giesbrecht)]

cpan2port should remove duplicate dependencies:

$ cpan2port -t Net::Works
...
$ grep moo perl/p5-net-works/Portfile 
                    port:p5${perl5.major}-moo \
                    port:p5${perl5.major}-moo \
                    port:p5${perl5.major}-moo \

[pixilla (Bradley Giesbrecht)]

My patch makes deps unique. Beware, I have very limited perl experience but my test results with Net::Works is what I was looking for.

[kurthindenburg (Kurt Hindenburg)]

Cc Me!

[mojca (Mojca Miklavec)]

I committed the changes in r129562 since nobody objected.

(The commit message is wrong about removal of 5.8 because 5.8 5.10 5.12 5.14 was already removed earlier and my version of the file was just outdated.)

Remaining issues (other than the need of testing):

• determine the licence automatically, at least for the most common types
• description is often missing, but META.yml usually contains abstract: that could be used (I don't know how to extract that)
• try to figure out if there is some desired order of keys (perl5.branches/perl5.setup/licence/maintainer/...)
• sometimes one ends up with weird dependencies, see the above exaple of cpan2port -t Mouse

[mojca (Mojca Miklavec)]

I added another sort into

$depends_build = join(" \\\n".(' 'x20), sort(@depends_build))."\n";

Maybe the first sort could go away (or this one could be moved elsewhere), but I'm not sure how to properly fix the code.

We could probably remove sort from here at least (I just noticed that I added that sort myself, but I added it at the wrong location):

cpan2port

@@ -242 +242 @@
              my @depends_build = Huggy::uniq map {
                  MSG::warn "$$info{name} build_requires $_";
                  'port:'.Huggy::from_port $_
-             } sort(keys %{ $dep_ref });
+             } keys %{ $dep_ref };
              if (@depends_build) {
                  unshift(@depends_build, '    depends_build-append');
                  $depends_build = join(" \\\n".(' 'x20), sort(@depends_build))."\n";
@@ -252 +252 @@
              my @depends_lib = Huggy::uniq map {
                  MSG::warn "$$info{name} requires $_";
                  'port:'.Huggy::from_port $_
-             } sort(keys %{ $dep_ref });
+             } keys %{ $dep_ref };
              if (@depends_lib) {
                  unshift(@depends_lib, '    depends_lib-append');
                  $depends_lib = join(" \\\n".(' 'x20), sort(@depends_lib))."\n";

[mojca (Mojca Miklavec)]

Another issue worth inspecting: trying to guess when to use perl5.use_module_build with p5-module-build-tiny instead of p5-module-build. See:

• ​http://trac.macports.org/ticket/46312