Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#44719 closed submission (fixed)

Add port cantera

Reported by: macports@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: dershow, g5pw (Aljaž Srebrnič)
Port: cantera

Description


Attachments (7)

Portfile (3.3 KB) - added by macports@… 10 years ago.
Portfile for cantera; added mention to select the appropriate python version
Portfile.2 (3.5 KB) - added by macports@… 10 years ago.
Portfile for cantera; modification 1
Portfile.3 (3.7 KB) - added by macports@… 10 years ago.
implemented comments by mf2k
Portfile.4 (2.7 KB) - added by macports@… 10 years ago.
implemented comments by mf2k and ryandesign
Portfile.5 (2.7 KB) - added by macports@… 10 years ago.
Portfile.6 (2.7 KB) - added by macports@… 10 years ago.
Version bumb 2.1.2
Portfile.7 (2.7 KB) - added by macports@… 10 years ago.
Cantera 2.1.2 on GitHub

Download all attachments as: .zip

Change History (26)

Changed 10 years ago by macports@…

Attachment: Portfile added

Portfile for cantera; added mention to select the appropriate python version

comment:1 Changed 10 years ago by dershow

Cc: dersh@… added

Cc Me!

comment:2 Changed 10 years ago by g5pw (Aljaž Srebrnič)

Are you interested in maintaining the port? I see that you listed both nomaintainer and openmaintainer. Nomaintainer means that the package is not maintained by anyone, openmaintainer means it is maintained by someone (the email of the maintainer must precede it). Also, don't use commas in the maintainer line.

If you fetch from github, perhaps you can use the github PortGroup to simplify the portfile a bit.

Is there a reason you disable fortran when building? We have a recipe to help select the correct fortran compiler, maybe you can use that.

Also, please don't use system words to move files, use the macports move word. Remember that system has a -W option to set the working directory, so you don't have to cd in.

comment:3 Changed 10 years ago by g5pw (Aljaž Srebrnič)

Cc: g5pw@… added

Cc Me!

comment:4 in reply to:  3 Changed 10 years ago by macports@…

Thank you for the valuable input! I modified the file according to your suggestions.

I now use the github PortGroup. However, this makes things a bit more difficult as this seems to conflict with setting sourceforge as the default master site. I had to add the default behavior as a "sourceforge" variant. Is there a better way to do this?

Cantera's Fortran interface is broken and currently not maintained, therefore I excluded that option.

Changed 10 years ago by macports@…

Attachment: Portfile.2 added

Portfile for cantera; modification 1

comment:5 Changed 10 years ago by mf2k (Frank Schima)

Some more comments - this is not a complete review:

  • Add sha256 and rmd160 checksums and remove the sha1 and md5 ones unless provided upstream.
  • Since you are using portgroups, and those often add dependencies, you need to replace depends_lib with depends_lib-append and depends_build with depends_build-append to not overwrite them.
  • The python portgroup is normally only for python modules. However, if this port requires python to build, that is ok. However, you must choose only one python version. That should be 2.7 since that is the default in Macports.
Last edited 10 years ago by mf2k (Frank Schima) (previous) (diff)

comment:6 Changed 10 years ago by mf2k (Frank Schima)

I removed my comment about FORTRAN after reading your comment:4. Sorry about that!

comment:7 Changed 10 years ago by mf2k (Frank Schima)

Also, unless I'm missing something, there is no point in using the github portgroup if you are downloading source from sourceforge.

Changed 10 years ago by macports@…

Attachment: Portfile.3 added

implemented comments by mf2k

comment:8 Changed 10 years ago by macports@…

Thanks for the comments, should be implemented.

comment:9 Changed 10 years ago by mf2k (Frank Schima)

More comments:

  • We don't allow variants to change the version. Instead you should use a subport. See the gnuradio port for an example. It has a gnuradio-devel subport in the same Portfile.
  • You need to obfuscate your email address: i.e. thomasfiala.de:macports
  • You do not need the following structure:
    post-install {
        notes-append
    

Just replace it with notes and do not have it inside a post-install block.

  • Remove the blank pre-destroot block

comment:10 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

You don't need to (and should not) gzip manpages manually; MacPorts does so for you automatically.

You may include the github portgroup just in the suggested cantera-devel subport, since it doesn't seem needed in the main stable-versioned port. However, such a cantera-devel subport must fetch from a specific commit, and the version must be set correspondingly; fetching from master is not allowed. See RepeatableBuilds.

Last edited 10 years ago by ryandesign (Ryan Carsten Schmidt) (previous) (diff)

Changed 10 years ago by macports@…

Attachment: Portfile.4 added

implemented comments by mf2k and ryandesign

comment:11 Changed 10 years ago by macports@…

Thanks again, it should be a lot cleaner now as well.

comment:12 Changed 10 years ago by macports@…

Hi, do you have any further comments or is it ready for a review?

comment:13 Changed 10 years ago by mf2k (Frank Schima)

A few more things:

  • You are using the default $distname and so that line should be deleted.
  • You reference "$prefix" and "$destroot" in a few places. Those should be "${prefix}" and "${destroot}". I don't know enough TCL to know the difference, but all other ports do it this way.

comment:14 Changed 10 years ago by macports@…

Thanks, I changed it! I assume that the curly braces only make a difference if you use compounds like ${python.version}. Also, $prefix without curly braces is often used in the MacPorts Guide. Nevertheless, I changed it in the cantera Portfile.

Changed 10 years ago by macports@…

Attachment: Portfile.5 added

comment:15 in reply to:  14 Changed 10 years ago by larryv (Lawrence Velázquez)

Replying to macports@…:

I assume that the curly braces only make a difference if you use compounds like ${python.version}. Also, $prefix without curly braces is often used in the MacPorts Guide.

Braces are required if the name of the scalar variable contains any character that isn’t a letter, digit, underscore, or Tcl namespace separator (two or more consecutive colons).

More to the point, our current style is to always use the braces in Portfiles, for consistency. Some of us also think it’s more readable.

Changed 10 years ago by macports@…

Attachment: Portfile.6 added

Version bumb 2.1.2

comment:16 Changed 10 years ago by macports@…

Do you have further comments or suggestions? I just modified the Portfile to match the latest version, which works smoothly.

comment:17 Changed 10 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Version: 2.3.1

Thanks for your patience. r125605.

Changed 10 years ago by macports@…

Attachment: Portfile.7 added

Cantera 2.1.2 on GitHub

comment:18 Changed 10 years ago by macports@…

Cantera is moving to GitHub. I modified the porfile to fetch the source from there. (Portfile.7)

comment:19 Changed 10 years ago by mf2k (Frank Schima)

Adding a Portfile to a closed ticket is not the correct procedure to get your update committed. Instead, create a new Update ticket and attach a unified diff of the current Portfile.

Note: See TracTickets for help on using tickets.