podofo: unnecessary cppunit dependency

[ryandesign (Ryan Carsten Schmidt)]

podofo declares a library dependency on cppunit, but does not appear to link with its libraries. If I read correctly, I think podofo only uses cppunit for unit tests, and the port does not declare "test.run yes" so I don't think the tests are running anyway. Could the dependency be removed?

[dbevans (David B. Evans)]

Yes, cppunit is only needed for unit tests which can be disabled by setting PODOFO_BUILD_LIB_ONLY=TRUE. Once that's done, the check for cppunit is disabled along with the tests and the dependency can be removed. Unfortunately, this also disables the build of the command line tools so I'm not in favor of this approach.

If the dependency is just removed as you suggest, then the port will build the tests if cppunit happens to be installed or not if not. This results in the same behavior as above -- if no cppunit, no tools.

So probably the best thing is to just make cppunit a build dependency.

I take it, cppunit is not your favorite port. Or are you lobbying to set test.run yes?

[ryandesign (Ryan Carsten Schmidt)]

I have no problem with cppunit, I am just working on the ticket for updating cppunit to the latest version. When I do that, its library version will change, so I will need to revbump all ports linking with cppunit, thus I've been investigating each port that declares a dependency on cppunit to determine if it links with the library.

[dbevans (David B. Evans)]

cppunit declared as a build dependency only in r124513. Installed files do not link with cppunit library so no need to revbump for library version changes.