#44771 closed update (fixed)
subversion-perlbindings: add perl 5.18 and 5.20 support
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | danielluke (Daniel J. Luke) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.99 |
Keywords: | haspatch | Cc: | blair (Blair Zajac) |
Port: | subversion-perlbindings |
Description
This patch adds 5.18 and 5.20 to the supported perl versions. I also made an incidental change to a string comparison (use eq
instead of ==
and use curly braces around variable names). Lastly, I changed the default perl version from 5.12 to 5.16 to match the rest of MacPorts.
The 5.18 subport builds for me, but the 5.20 doesn't:
make: *** No rule to make target `install-swig-pl-lib'. Stop.
Could you investigate and fix? This blocks other updates I'm wanting to commit.
Attachments (1)
Change History (5)
Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Attachment: | subversion-perlbindings.diff added |
---|
comment:1 Changed 10 years ago by danielluke (Daniel J. Luke)
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Thanks! Upon trying again, it worked for me as well. It was a destroot failure before, so it can't really have been a parallel build failure. Not sure what that was but glad it's working now.
comment:3 follow-up: 4 Changed 10 years ago by jmroot (Joshua Root)
Surely that replaced_by can go away by now?
comment:4 Changed 10 years ago by danielluke (Daniel J. Luke)
Replying to jmr@…:
Surely that replaced_by can go away by now?
only if we want it to no longer mimic the perl5 portgroup (which does something similar for the p5- ports...
replaced_by p[option perl5.default_branch]-${rootname} depends_lib port:p[option perl5.default_branch]-${rootname}
Ryan - I couldn't replicate your build failure with perl5.20, so I committed p5.18 and p5.20 both in r124714.