Opened 10 years ago

Closed 10 years ago

#44784 closed enhancement (fixed)

py-tox: please add Python 3 ports

Reported by: cdeil (Christoph Deil) Owned by: steenzout (Pedro Salgado)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: petrrr
Port: py-tox

Description

I'm trying to move from Python 2.7 to Python 3.4 and tox is one of the very few packages I use that don't have Python 3 ports yet.

Would it be possible to add py33-tox and py34-tox?

It's definitely supported

Attachments (3)

py-tox-1.8.0_20141007.tgz (1.3 KB) - added by steenzout (Pedro Salgado) 10 years ago.
tarball of py-tox package. added support for v1.8.0 and python3.
py-tox-1.8.0_20141007.2.tgz (1.3 KB) - added by steenzout (Pedro Salgado) 10 years ago.
Portfile.diff (1015 bytes) - added by steenzout (Pedro Salgado) 10 years ago.
1.7.1 to 1.8.0 diff

Download all attachments as: .zip

Change History (17)

comment:1 Changed 10 years ago by mf2k (Frank Schima)

Cc: pedro.salgado@… removed
Owner: changed from macports-tickets@… to pedro.salgado@…
Version: 2.3.1

comment:2 Changed 10 years ago by petrrr

Cc: petr@… added

Cc Me!

comment:3 Changed 10 years ago by petrrr

Looks like tox is now at varsion 1.8.0. So should be updated as well.

comment:4 in reply to:  description Changed 10 years ago by steenzout (Pedro Salgado)

sorry for the delay. I've got the patch ready for 1.8.0 and support for python3.1/2/3/4.

Replying to Deil.Christoph@…:

I'm trying to move from Python 2.7 to Python 3.4 and tox is one of the very few packages I use that don't have Python 3 ports yet.

Would it be possible to add py33-tox and py34-tox?

It's definitely supported

Changed 10 years ago by steenzout (Pedro Salgado)

Attachment: py-tox-1.8.0_20141007.tgz added

tarball of py-tox package. added support for v1.8.0 and python3.

comment:5 Changed 10 years ago by petrrr

Please, do remove py31 and py32 these are deprecated be added for new ports.

Changed 10 years ago by steenzout (Pedro Salgado)

Attachment: py-tox-1.8.0_20141007.2.tgz added

comment:6 Changed 10 years ago by petrrr

Also, please provide patches to existing files always as unified diffs. Thanks!

comment:7 Changed 10 years ago by steenzout (Pedro Salgado)

what do you mean by unified diff? is the Portfile.diff enough?

comment:8 Changed 10 years ago by steenzout (Pedro Salgado)

please ignore the Portfile on the tarball since the checksums are wrong. the Portfile.diff has the correct information (tested it on my laptop).

comment:9 Changed 10 years ago by petrrr

Unified diff refers to the format of a diff output. It is better suited for automated patching and trac provides a nice rendering of it. You will get a unified diff with -u flag to diff.

Changed 10 years ago by steenzout (Pedro Salgado)

Attachment: Portfile.diff added

1.7.1 to 1.8.0 diff

comment:10 Changed 10 years ago by steenzout (Pedro Salgado)

ok, now with -u option. also saw I was missing 33 and 34 on the python.versions line.

comment:11 Changed 10 years ago by petrrr

Perfect, I will take care of this later ...

comment:12 Changed 10 years ago by petrrr

Done in r126316. Thanks!

Pedro, please consider to add openmainter. As you have no commit rights yet, this is highly encouraged to reduce turn over times of minor modifications.

Last edited 10 years ago by petrrr (previous) (diff)

comment:13 Changed 10 years ago by petrrr

In r126320, adapt the select files to the new subport set. This was missing in the previous changeset.

comment:14 Changed 10 years ago by petrrr

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.