Opened 10 years ago

Closed 10 years ago

#44803 closed defect (fixed)

ola: cppunit library dependency?

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: nomis52@…
Priority: Normal Milestone:
Component: ports Version: 2.3.99
Keywords: haspatch Cc: p3k (Tobi Schäfer)
Port: ola

Description

ola declares a library dependency on cppunit, but does not appear to dynamically link with cppunit's library. Should it be a build dependency instead, or is cppunit really used by ola at runtime?

Attachments (1)

Portfile.diff (254 bytes) - added by nomis52@… 10 years ago.

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by nomis52@…

Attachment: Portfile.diff added

comment:1 Changed 10 years ago by nomis52@…

It's using during the test phase. Since there doesn't appear to be a depends_test, I'd agree that depends_build would be the correct place to list this.

I've attached a patch.

comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Resolution: fixed
Status: newclosed

Sounds good. Committed in r124834. I added a comment to remind us to change it to depends_test once that's implemented.

Note: See TracTickets for help on using tickets.