Opened 10 years ago

Closed 2 years ago

#44829 closed update (fixed)

itcl: update to 4.0.1

Reported by: jul_bsd@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: ryandesign (Ryan Carsten Schmidt), ChrisFr, chrstphrchvz (Christopher Chavez), MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Port: itcl

Description

  • bump to 4.0.1
  • subport 3 for 3.4.1
  • tcl from 8.5.9 to 8.6.2
  • fix livecheck
  • universal: fails to build

Attachments (1)

patch-itcl-Portfile.diff (6.8 KB) - added by jul_bsd@… 10 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

The files of one of the subports (perhaps the older version) should be renamed or moved so that the subports do not conflict.

comment:2 Changed 10 years ago by jul_bsd@…

subport name and 3 are already conflicted each other.

are you speaking about "Error: org.macports.activate for port itcl returned: Image error: /opt/local/include/itcl.h is being used by the active tcl port. + many other files..." ? For this, try to add "--includedir=${prefix}/include/itcl" but it seems to have no effect...

comment:3 Changed 10 years ago by jul_bsd@…

  • move headers to include/itcl4
  • 4.0.2

Changed 10 years ago by jul_bsd@…

Attachment: patch-itcl-Portfile.diff added

comment:4 Changed 10 years ago by petrrr

Summary: update itclitcl: update to 4.0.1

comment:5 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added

In this diff you make a whole lot of changes at once, including whitespace changes to the whole file, which make it very difficult to evaluate your functional changes. Whitespace changes should be kept separate from functional changes.

I'm also not sure why you've added a subport for 3.4.1. Can't we just update the port to 4.0.1? We can add an itcl3 port later if someone really needs it, but I don't know if anyone does.

If we need to keep 3.4.1, it might be more straightforward to have it in a separate portfile. I think we shouldn't overuse MacPorts' subport feature.

comment:6 Changed 9 years ago by jharmon@…

I'm just adding my desire to have this remedied. It looks like they're at 4.0.3 now, and it's well-maintained.

comment:7 Changed 7 years ago by ChrisFr

I'm trying to install msort, which has itcl as a dependency. itcl is still sitting at 3.4, which has the build problem noted in #47817.

Is there any likelihood of itcl moving forward or is msort now effectively a dead twig on the port tree? Opinions?

comment:8 Changed 7 years ago by ChrisFr

Cc: ChrisFr added

comment:9 Changed 6 years ago by chrstphrchvz (Christopher Chavez)

The latest itcl is 4.1.2, and it is included in MacPorts' tcl 8.6.9.

Because itcl is bundled with Tcl, should the itcl port be discontinued?

comment:10 Changed 6 years ago by chrstphrchvz (Christopher Chavez)

Cc: chrstphrchvz added

comment:11 Changed 6 years ago by chrstphrchvz (Christopher Chavez)

When checking with one of the itcl authors what the latest version is (4.1.2 wasn't uploaded to Sourceforge), they pointed out that some may still prefer itcl 3 to itcl 4 (latest itcl 3 is 3.4.3, released 2016).

However, given how long this port has been in a non-working state (maybe the bundled itcl in tcl was enough), should a port for itcl 3.4.3 even be considered?

Would it be a good idea to CC Marcus to this ticket?

comment:12 Changed 6 years ago by mf2k (Frank Schima)

Cc: MarcusCalhoun-Lopez added

Cc'ing Marcus for possible comment.

comment:13 Changed 2 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed

In bf63f2f5d26b998a135747086fb7903553908b0c/macports-ports (master):

itcl: mark replaced_by tcl

Included in the core Tcl distribution as of 8.6.

Closes: #44829
Closes: #47817

Note: See TracTickets for help on using tickets.