Opened 10 years ago

Closed 8 years ago

#44842 closed submission (fixed)

[NEW] wkhtmltopdf

Reported by: jul_bsd@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: wkhtmltopdf

Description

Convert HTML to PDF using Webkit (QtWebKit)

Attachments (1)

Portfile (3.6 KB) - added by jul_bsd@… 10 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Thanks. Is there a specific reason why you've set the ${name}-devel subport to use fetch.type git? Usually that's unnecessary and undesirable.

Changed 10 years ago by jul_bsd@…

Attachment: Portfile added

comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

I see you've attached a new portfile. Note that Trac does not send email notifications for attachments, so if you want us to notice when you've attached a new file, please also write a comment in the ticket.

I see you've changed the ${name}-devel subport to no longer use fetch.type git, but now you're setting master_sites, distname, use_zip and worksrcdir. As I've explained elsewhere, it's unexpected for you to need to set those when using the github portgroup. Its defaults should work fine. Just run github.setup, and possibly github.tarball_from. In this case, where you've already set github.setup in the main port and want to override some of its values in the subport, just override what you need to: in this case, git.branch. Read the documentation in the github portgroup file for more info, though it's probably worth adding a section to the documentation about this unanticipated use case of overriding the version in a devel subport.

This new file also has lots of commented-out code and stuff that needs to be fixed.

comment:3 Changed 8 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed

I wasn't even aware of this ticket and the in-progress Portfile, but I've meanwhile re-implemented this port against Qt5 (which is still in development upstream, but seems to work well enough).

Committed in r149650.

Note: See TracTickets for help on using tickets.