Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#45092 closed submission (fixed)

Adding jemalloc portfile

Reported by: c9s (Yo-An Lin) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: kurthindenburg (Kurt Hindenburg)
Port: jemalloc

Description


Attachments (2)

Portfile (1.2 KB) - added by c9s (Yo-An Lin) 10 years ago.
memalign.diff (798 bytes) - added by c9s (Yo-An Lin) 10 years ago.
Patch file

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by c9s (Yo-An Lin)

Attachment: Portfile added

Changed 10 years ago by c9s (Yo-An Lin)

Attachment: memalign.diff added

Patch file

comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Thanks. Some observations:

  • "openmaintainer" is not a valid maintainer, by itself. If you don't want to maintain the port, the correct value is "nomaintainer"
  • Why rename files in post-extract?
  • The unused commented-out code should be removed

comment:2 Changed 10 years ago by c9s (Yo-An Lin)

The updated PortFile: https://github.com/c9s/hhvm-macports/blob/master/facebook/jemalloc/Portfile

Patch file: https://github.com/c9s/hhvm-macports/tree/master/facebook/jemalloc/files

  • maintainer field is updated
  • because it conflict with google profiler (pprof)
  • removed.

comment:3 Changed 10 years ago by c9s (Yo-An Lin)

Hi! Please take a look, I've updated the patch.

comment:4 Changed 10 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:5 Changed 10 years ago by kurthindenburg (Kurt Hindenburg)

Appears to build OK and tests pass; for future reference, try to use 'port lint --nitpick'; you missed a 'platforms darwin' in the Portfile.

bin/pprof doesn't exist - did you mean bin/jemalloc-prof ?

post-extract {
    move ${worksrcpath}/bin/pprof ${worksrcpath}/bin/jemalloc-prof
}

comment:6 Changed 10 years ago by c9s (Yo-An Lin)

Yes, bin/jemalloc-prof

comment:7 Changed 10 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

done w/ a few minor changes r128794

comment:8 Changed 9 years ago by mf2k (Frank Schima)

Port: jemalloc added
Version: 2.3.1
Note: See TracTickets for help on using tickets.