#45092 closed submission (fixed)
Adding jemalloc portfile
Reported by: | c9s (Yo-An Lin) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | kurthindenburg (Kurt Hindenburg) | |
Port: | jemalloc |
Description
Attachments (2)
Change History (10)
Changed 10 years ago by c9s (Yo-An Lin)
Changed 10 years ago by c9s (Yo-An Lin)
Attachment: | memalign.diff added |
---|
comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Thanks. Some observations:
- "openmaintainer" is not a valid maintainer, by itself. If you don't want to maintain the port, the correct value is "nomaintainer"
- Why rename files in post-extract?
- The unused commented-out code should be removed
comment:2 Changed 10 years ago by c9s (Yo-An Lin)
The updated PortFile: https://github.com/c9s/hhvm-macports/blob/master/facebook/jemalloc/Portfile
Patch file: https://github.com/c9s/hhvm-macports/tree/master/facebook/jemalloc/files
- maintainer field is updated
- because it conflict with google profiler (pprof)
- removed.
comment:5 Changed 10 years ago by kurthindenburg (Kurt Hindenburg)
Appears to build OK and tests pass; for future reference, try to use 'port lint --nitpick'; you missed a 'platforms darwin' in the Portfile.
bin/pprof doesn't exist - did you mean bin/jemalloc-prof ?
post-extract { move ${worksrcpath}/bin/pprof ${worksrcpath}/bin/jemalloc-prof }
comment:7 Changed 10 years ago by kurthindenburg (Kurt Hindenburg)
Resolution: | → fixed |
---|---|
Status: | new → closed |
done w/ a few minor changes r128794
comment:8 Changed 9 years ago by mf2k (Frank Schima)
Port: | jemalloc added |
---|---|
Version: | 2.3.1 |
Note: See
TracTickets for help on using
tickets.
Patch file